Skip to content

Commit 19925a0

Browse files
aivanoufacebook-github-bot
authored andcommitted
Do not check torchx.components.base module for components (#258)
Summary: Pull Request resolved: #258 Do not check `torchx.components.base` module for components Reviewed By: kiukchung Differential Revision: D31664832 fbshipit-source-id: 3de72047810ff8c2478e036ce5626459d4c073af
1 parent 37311e4 commit 19925a0

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

torchx/specs/finder.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,13 @@ def _get_components_from_dir(
119119
search_pattern = os.path.join(search_dir, "**", "*.py")
120120
component_defs = []
121121
for filepath in glob.glob(search_pattern, recursive=True):
122-
module = self._try_load_module(
123-
self._get_module_name(filepath, search_dir, base_module)
124-
)
122+
module_name = self._get_module_name(filepath, search_dir, base_module)
123+
# TODO(aivanou): move `torchx.components.base` to `torchx.specs`, since
124+
# there is nothing related to components in `torchx.components.base`
125+
# see https://github.com/pytorch/torchx/issues/261
126+
if module_name.startswith("torchx.components.base"):
127+
continue
128+
module = self._try_load_module(module_name)
125129
defs = self._get_components_from_module(base_module, module)
126130
component_defs += defs
127131
return component_defs

0 commit comments

Comments
 (0)