Skip to content

Commit 5b979cf

Browse files
kiukchungfacebook-github-bot
authored andcommitted
Fix broken docs-build by pinning protobuf-3.20.x (#1033)
Summary: Pull Request resolved: #1033 Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x. What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
1 parent d633108 commit 5b979cf

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.github/workflows/doc-build.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,15 @@ jobs:
2020
architecture: x64
2121
- name: Checkout TorchX
2222
uses: actions/checkout@v2
23-
- name: Install Dependencies
23+
- name: Install Doc Dependencies
2424
run: |
2525
set -eux
2626
sudo apt-get update
2727
sudo apt-get install -y pandoc
28-
pip install -e .[dev]
2928
pip install -r docs/requirements.txt
3029
- name: Install TorchX
3130
run: |
32-
python setup.py develop
31+
pip install -e .[dev]
3332
- name: Start Airflow
3433
run: |
3534
# start airflow in background

.github/workflows/pyre.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ jobs:
2222
set -eux
2323
pip install -e .[dev]
2424
- name: Init Lint Runner
25-
lintrunner init
25+
run: lintrunner init
2626
- name: Run Pyre
2727
run: scripts/pyre.sh

dev-requirements.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ google-cloud-runtimeconfig==0.34.0
1414
hydra-core
1515
ipython
1616
kfp==1.8.22
17+
# pin protobuf to the version that is required by kfp
18+
protobuf==3.20.3
1719
mlflow-skinny
1820
moto~=5.0.8
1921
pyre-extensions

0 commit comments

Comments
 (0)