Have versioning be in a single place for 3 cases

Summary: Goal here is to have one single place for version that will be manully updated.

Differential Revision: D83858764

Author: AbishekS

setup.py

@@ -5,24 +5,13 @@
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
-import os
-import re
 import sys
 from datetime import date
 
+from base_version_gen import BASE_VERSION
 from setuptools import find_packages, setup
 
 
-def get_version():
-    # get version string from version.py
-    # TODO: ideally the version.py should be generated when setup is run
-    version_file = os.path.join(os.path.dirname(__file__), "torchx/version.py")
-    version_regex = r"__version__ = ['\"]([^'\"]*)['\"]"
-    with open(version_file, "r") as f:
-        version = re.search(version_regex, f.read(), re.M).group(1)
-        return version
-
-
 def get_nightly_version():
     today = date.today()
     return f"{today.year}.{today.month}.{today.day}"
@@ -49,7 +38,7 @@ def get_nightly_version():
     with open("dev-requirements.txt") as f:
         dev_reqs = f.read()
 
-    version = get_nightly_version() if is_nightly else get_version()
+    version = get_nightly_version() if is_nightly else BASE_VERSION
     print(f"-- {name} building version: {version}")
 
     setup(

torchx/base_version_gen.py

@@ -0,0 +1,9 @@
+#!/usr/bin/env python3
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+# All rights reserved.
+#
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+# pyre-strict
+BASE_VERSION = "0.8.0dev0"

torchx/version.py

@@ -9,6 +9,8 @@
 
 from torchx.util.entrypoints import load
 
+from .version_gen import get_fb_version
+
 # Follows PEP-0440 version scheme guidelines
 # https://www.python.org/dev/peps/pep-0440/#version-scheme
 #
@@ -18,7 +20,7 @@
 # 0.1.0bN  # Beta release
 # 0.1.0rcN  # Release Candidate
 # 0.1.0  # Final release
-__version__ = "0.8.0dev0"
+__version__: str = get_fb_version()
 
 
 # Use the github container registry images corresponding to the current package

torchx/version_gen.py

@@ -0,0 +1,51 @@
+#!/usr/bin/env python3
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+# All rights reserved.
+#
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+# pyre-strict
+import os
+import subprocess
+from typing import Optional
+
+from .base_version_gen import BASE_VERSION
+
+
+def get_mercurial_hash() -> Optional[str]:
+    """Get the current mercurial revision hash."""
+    try:
+        # Try to get the mercurial hash from the current working directory
+        result = subprocess.run(
+            ["hg", "id", "-i"],
+            capture_output=True,
+            text=True,
+            check=True,
+            cwd=os.path.dirname(__file__),
+        )
+        # Remove the '+' suffix that indicates uncommitted changes
+        hg_hash = result.stdout.strip().rstrip("+")
+        return hg_hash
+    except (subprocess.CalledProcessError, FileNotFoundError):
+        # If hg command fails or is not available, return None
+        return None
+
+
+def get_fb_version() -> str:
+    """
+    Get the torchx version string.
+
+    Returns:
+        Version string following semantic versioning specs
+    """
+    hg_hash = get_mercurial_hash()
+    if hg_hash:
+        # Follow semantic versioning local version identifier format
+        # https://packaging.python.org/en/latest/specifications/version-specifiers/#local-version-identifiers
+        version = f"{BASE_VERSION}+fb.{hg_hash}"
+    else:
+        # Fallback if we can't get mercurial hash
+        version = f"{BASE_VERSION}+fb"
+
+    return version