Remove AppDef builder methods (#81)

Summary:
Pull Request resolved: #81

The diff removes ``of``, ``get_metadata`` and ``add_metadata`` methods from the ``AppDef`` class

Reviewed By: kiukchung

Differential Revision: D29176342

fbshipit-source-id: 99d1af4296f50213394980a5f9456c9b604aec7f

Author: aivanou

torchx/cli/test/cmd_describe_test.py

@@ -26,7 +26,7 @@ def get_test_app(self) -> AppDef:
             num_replicas=2,
             nnodes="2:3",
         )
-        return AppDef("my_train_job").of(trainer)
+        return AppDef("my_train_job", roles=[trainer])
 
     def test_run(self) -> None:
         parser = argparse.ArgumentParser()

torchx/components/dist.py

@@ -63,4 +63,4 @@ def ddp(
         max_restarts=0,
     )
 
-    return specs.AppDef(name).of(ddp_role)
+    return specs.AppDef(name, roles=[ddp_role])

torchx/runner/api.py

@@ -236,7 +236,7 @@ def dryrun(
         # input validation
         if not app.roles:
             raise ValueError(
-                f"No roles for app: {app.name}. Did you forget to call app.of(roles..)?"
+                f"No roles for app: {app.name}. Did you forget to add roles to AppDef?"
             )
 
         for role in app.roles:
@@ -394,7 +394,7 @@ def describe(self, app_handle: AppHandle) -> Optional[AppDef]:
             if not app:
                 desc = scheduler.describe(app_id)
                 if desc:
-                    app = AppDef(name=app_id).of(*desc.roles)
+                    app = AppDef(name=app_id, roles=desc.roles)
             return app
 
     def log_lines(

torchx/specs/api.py

@@ -280,21 +280,6 @@ class AppDef:
     roles: List[Role] = field(default_factory=list)
     metadata: Dict[str, str] = field(default_factory=dict)
 
-    def of(self, *roles: Role) -> "AppDef":
-        self.roles += [*roles]
-        return self
-
-    def add_metadata(self, key: str, value: str) -> "AppDef":
-        """
-        Adds metadata to the application.
-        .. note:: If the key already exists, this method overwrites the metadata value.
-        """
-        self.metadata[key] = value
-        return self
-
-    def get_metadata(self, key: str) -> Optional[str]:
-        return self.metadata.get(key)
-
 
 class AppState(int, Enum):
     """

torchx/specs/test/api_test.py

@@ -194,9 +194,9 @@ def test_application_default(self) -> None:
         self.assertEqual(0, len(app.roles))
 
     def test_getset_metadata(self) -> None:
-        app = AppDef(name="test_app").add_metadata("test_key", "test_value")
-        self.assertEqual("test_value", app.get_metadata("test_key"))
-        self.assertEqual(None, app.get_metadata("non_existent"))
+        app = AppDef(name="test_app", metadata={"test_key": "test_value"})
+        self.assertEqual("test_value", app.metadata["test_key"])
+        self.assertEqual(None, app.metadata.get("non_existent"))
 
 
 class RunConfigTest(unittest.TestCase):