-
Notifications
You must be signed in to change notification settings - Fork 146
handle components whose implementation lives in a different file #1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle components whose implementation lives in a different file #1075
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
…a-pytorch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Differential Revision: D75496839
f3f9002 to
2a129b6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
…a-pytorch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Differential Revision: D75496839
2a129b6 to
005b5d5
Compare
…a-pytorch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Differential Revision: D75496839
005b5d5 to
9590188
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
…a-pytorch#1075) Summary: Pull Request resolved: meta-pytorch#1075 Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Differential Revision: D75496839
9590188 to
8652b4f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
…a-pytorch#1075) Summary: Pull Request resolved: meta-pytorch#1075 Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Differential Revision: D75496839
8652b4f to
78e9b5b
Compare
…a-pytorch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
78e9b5b to
1bf54ab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
1bf54ab to
1eba6d0
Compare
…a-pytorch#1075) Summary: Pull Request resolved: meta-pytorch#1075 Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
1eba6d0 to
5de962f
Compare
…a-pytorch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
…a-pytorch#1075) Summary: Pull Request resolved: meta-pytorch#1075 Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
5de962f to
83a2af4
Compare
…a-pytorch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
83a2af4 to
9c22799
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
…a-pytorch#1075) Summary: Pull Request resolved: meta-pytorch#1075 Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
9c22799 to
bf91c0c
Compare
…a-pytorch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
bf91c0c to
ec1c0de
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
…a-pytorch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
ec1c0de to
fbc5ad2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
…a-pytorch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
fbc5ad2 to
b1f7910
Compare
…a-pytorch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
b1f7910 to
fa562d5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
…a-pytorch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
…a-pytorch#1075) Summary: Pull Request resolved: meta-pytorch#1075 Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
fa562d5 to
7984d58
Compare
…a-pytorch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
b860670 to
e9dd297
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
…a-pytorch#1075) Summary: Pull Request resolved: meta-pytorch#1075 Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
e9dd297 to
5cb0c3e
Compare
…96839 and D82132556) Summary: Reverting #1075 as it can cause issues with decorated functions. Reviewed By: kiukchung Differential Revision: D82492135
Summary:
Add support for cases like:
where the component is invoked with
torchx run ... other_file.py:my_componentThis was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented.
Differential Revision: D75496839