Add a dataclass to represent torchx run command args (#1105) #1106
+258
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80279871 |
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 2, 2025
Summary: Add a dataclass to represent `torchx run` command arguments, and a function to deserialize JSONs into the dataclass. This will be helpful when adding the functionality to pipe JSONs in as the entire `torchx run` command (eg, `JSON | torchx run`). Reviewed By: daniel-ohayon Differential Revision: D80279871
ethanbwaite
approved these changes
Sep 2, 2025
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 2, 2025
Summary: Add a dataclass to represent `torchx run` command arguments, and a function to deserialize JSONs into the dataclass. This will be helpful when adding the functionality to pipe JSONs in as the entire `torchx run` command (eg, `JSON | torchx run`). Reviewed By: daniel-ohayon Differential Revision: D80279871
ishachirimar
force-pushed
the
export-D80279871
branch
from
e73a492 to
f6ad19e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80279871 |
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 2, 2025
Summary: Add a dataclass to represent `torchx run` command arguments, and a function to deserialize JSONs into the dataclass. This will be helpful when adding the functionality to pipe JSONs in as the entire `torchx run` command (eg, `JSON | torchx run`). Reviewed By: daniel-ohayon Differential Revision: D80279871
Summary: Add a dataclass to represent `torchx run` command arguments, and a function to deserialize JSONs into the dataclass. This will be helpful when adding the functionality to pipe JSONs in as the entire `torchx run` command (eg, `JSON | torchx run`). Reviewed By: daniel-ohayon Differential Revision: D80279871
ishachirimar
force-pushed
the
export-D80279871
branch
from
f6ad19e to
637f7b2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80279871 |
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 2, 2025
Summary: Add a dataclass to represent `torchx run` command arguments, and a function to deserialize JSONs into the dataclass. This will be helpful when adding the functionality to pipe JSONs in as the entire `torchx run` command (eg, `JSON | torchx run`). Reviewed By: daniel-ohayon Differential Revision: D80279871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a dataclass to represent
torchx runcommand arguments, and a function to deserialize JSONs into the dataclass.This will be helpful when adding the functionality to pipe JSONs in as the entire
torchx runcommand (eg,JSON | torchx run).Reviewed By: daniel-ohayon
Differential Revision: D80279871