Support JSON input to torchx run #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80731827 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80731827 |
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 2, 2025
Summary: Pull Request resolved: meta-pytorch#1107 add support for piping a json into torchx run command, like `JSON | torchx run` where the JSON contains the args for torchx run (while maintaining the functionality of the regular CLI) This can be done with either a JSON directly in the terminal or `cat json_file.json`. Next steps: - add a json schema to improve authoring experience for this new config format - more robust validation - accept varargs for component args/ test this case Reviewed By: daniel-ohayon Differential Revision: D80731827
ishachirimar
force-pushed
the
export-D80731827
branch
from
d462df9 to
42c14dd
Compare
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 2, 2025
Summary: add support for piping a json into torchx run command, like `JSON | torchx run` where the JSON contains the args for torchx run (while maintaining the functionality of the regular CLI) This can be done with either a JSON directly in the terminal or `cat json_file.json`. Next steps: - add a json schema to improve authoring experience for this new config format - more robust validation - accept varargs for component args/ test this case Reviewed By: daniel-ohayon Differential Revision: D80731827
ishachirimar
force-pushed
the
export-D80731827
branch
from
42c14dd to
ea26d04
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80731827 |
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 2, 2025
Summary: add support for piping a json into torchx run command, like `JSON | torchx run` where the JSON contains the args for torchx run (while maintaining the functionality of the regular CLI) This can be done with either a JSON directly in the terminal or `cat json_file.json`. Next steps: - add a json schema to improve authoring experience for this new config format - more robust validation - accept varargs for component args/ test this case Reviewed By: daniel-ohayon Differential Revision: D80731827
ishachirimar
force-pushed
the
export-D80731827
branch
from
ea26d04 to
c0d3def
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80731827 |
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 2, 2025
Summary: add support for piping a json into torchx run command, like `JSON | torchx run` where the JSON contains the args for torchx run (while maintaining the functionality of the regular CLI) This can be done with either a JSON directly in the terminal or `cat json_file.json`. Next steps: - add a json schema to improve authoring experience for this new config format - more robust validation - accept varargs for component args/ test this case Reviewed By: daniel-ohayon Differential Revision: D80731827
ishachirimar
force-pushed
the
export-D80731827
branch
from
c0d3def to
a6ced3a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80731827 |
ishachirimar
force-pushed
the
export-D80731827
branch
from
a6ced3a to
1154bc8
Compare
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 3, 2025
Summary: add support for piping a json into torchx run command, like `JSON | torchx run` where the JSON contains the args for torchx run (while maintaining the functionality of the regular CLI) This can be done with either a JSON directly in the terminal or `cat json_file.json`. Next steps: - add a json schema to improve authoring experience for this new config format - more robust validation - accept varargs for component args/ test this case Reviewed By: daniel-ohayon Differential Revision: D80731827
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80731827 |
lgarg26
approved these changes
Sep 3, 2025
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 3, 2025
Summary: add support for piping a json into torchx run command, like `JSON | torchx run` where the JSON contains the args for torchx run (while maintaining the functionality of the regular CLI) This can be done with either a JSON directly in the terminal or `cat json_file.json`. Next steps: - add a json schema to improve authoring experience for this new config format - more robust validation - accept varargs for component args/ test this case Reviewed By: daniel-ohayon Differential Revision: D80731827
ishachirimar
force-pushed
the
export-D80731827
branch
from
1154bc8 to
90ee821
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80731827 |
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 3, 2025
Summary: add support for piping a json into torchx run command, like `JSON | torchx run` where the JSON contains the args for torchx run (while maintaining the functionality of the regular CLI) This can be done with either a JSON directly in the terminal or `cat json_file.json`. Next steps: - add a json schema to improve authoring experience for this new config format - more robust validation - accept varargs for component args/ test this case Reviewed By: daniel-ohayon Differential Revision: D80731827
ishachirimar
force-pushed
the
export-D80731827
branch
from
90ee821 to
0a32e0f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80731827 |
Summary: add support for piping a json into torchx run command, like `JSON | torchx run` where the JSON contains the args for torchx run (while maintaining the functionality of the regular CLI) This can be done with either a JSON directly in the terminal or `cat json_file.json`. Next steps: - add a json schema to improve authoring experience for this new config format - more robust validation - accept varargs for component args/ test this case Reviewed By: daniel-ohayon Differential Revision: D80731827
ishachirimar
force-pushed
the
export-D80731827
branch
from
0a32e0f to
350a8a7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80731827 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
add support for piping a json into torchx run command, like
JSON | torchx runwhere the JSON contains the args for torchx run (while maintaining the functionality of the regular CLI)
This can be done with either a JSON directly in the terminal or
cat json_file.json.Next steps:
Reviewed By: daniel-ohayon
Differential Revision: D80731827