Support flow orchestrator launches in JSON mode #1108
Merged
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81705462 |
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 4, 2025
Summary: `OrchestratorRunner` was not being correctly initialized for JSON cases since the JSON input was parsed after Runner initialized. This diff moves some of the logic around to make sure: - in FB version, the correct scheduler is logged - JSON parsing isn't repeated unnecessarily - if JSON mode is used, the scheduler is parsed before getting the runner to account for `single_orchestrator_runner` scheduler usage Differential Revision: D81705462
ishachirimar
force-pushed
the
export-D81705462
branch
from
071c8b5 to
1627ba2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81705462 |
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 4, 2025
Summary: `OrchestratorRunner` was not being correctly initialized for JSON cases since the JSON input was parsed after Runner initialized. This diff moves some of the logic around to make sure: - in FB version, the correct scheduler is logged - JSON parsing isn't repeated unnecessarily - if JSON mode is used, the scheduler is parsed before getting the runner to account for `single_orchestrator_runner` scheduler usage Differential Revision: D81705462
ishachirimar
force-pushed
the
export-D81705462
branch
from
1627ba2 to
ebac966
Compare
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 4, 2025
Summary: `OrchestratorRunner` was not being correctly initialized for JSON cases since the JSON input was parsed after Runner initialized. This diff moves some of the logic around to make sure: - in FB version, the correct scheduler is logged - JSON parsing isn't repeated unnecessarily - if JSON mode is used, the scheduler is parsed before getting the runner to account for `single_orchestrator_runner` scheduler usage Differential Revision: D81705462
ishachirimar
force-pushed
the
export-D81705462
branch
from
ebac966 to
d76af29
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81705462 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81705462 |
ishachirimar
added a commit
to ishachirimar/torchx
that referenced
this pull request
Sep 4, 2025
Summary: Pull Request resolved: meta-pytorch#1108 `OrchestratorRunner` was not being correctly initialized for JSON cases since the JSON input was parsed after Runner initialized. This diff moves some of the logic around to make sure: - in FB version, the correct scheduler is logged - JSON parsing isn't repeated unnecessarily - if JSON mode is used, the scheduler is parsed before getting the runner to account for `single_orchestrator_runner` scheduler usage Differential Revision: D81705462
ishachirimar
force-pushed
the
export-D81705462
branch
from
d76af29 to
9899372
Compare
Summary: `OrchestratorRunner` was not being correctly initialized for JSON cases since the JSON input was parsed after Runner initialized. This diff moves some of the logic around to make sure: - in FB version, the correct scheduler is logged - JSON parsing isn't repeated unnecessarily - if JSON mode is used, the scheduler is parsed before getting the runner to account for `single_orchestrator_runner` scheduler usage Reviewed By: daniel-ohayon Differential Revision: D81705462
ishachirimar
force-pushed
the
export-D81705462
branch
from
9899372 to
7125d80
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81705462 |
ethanbwaite
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
OrchestratorRunnerwas not being correctly initialized for JSON cases since the JSON input was parsed after Runner initialized.This diff moves some of the logic around to make sure:
single_orchestrator_runnerscheduler usageDifferential Revision: D81705462