(torchx/specs) component fn python-3.10 compatibility. Support BinOp for optional types and builtin container types. #1110
+262
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81826386 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81826386 |
kiukchung
force-pushed
the
export-D81826386
branch
from
09c2172 to
ed6f82e
Compare
kiukchung
added a commit
that referenced
this pull request
Sep 9, 2025
…for optional types and builtin container types. (#1110) Summary: Pull Request resolved: #1110 For python-3.10, support type annotations in component fn arguments using builtin `dict`, `list`, `tuple` types and `|` for Optional types. Allows component fn to be typed as: ``` def foo(env: dict[str, str] | None): pass ``` versus ``` from typing import Dict, Optional def foo(env: Optional[Dict[str, str]]): pass ``` Reviewed By: highker Differential Revision: D81826386
ethanbwaite
approved these changes
Sep 9, 2025
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81826386 |
kiukchung
added a commit
that referenced
this pull request
Sep 9, 2025
…for optional types and builtin container types. (#1110) Summary: Pull Request resolved: #1110 For python-3.10, support type annotations in component fn arguments using builtin `dict`, `list`, `tuple` types and `|` for Optional types. Allows component fn to be typed as: ``` def foo(env: dict[str, str] | None): pass ``` versus ``` from typing import Dict, Optional def foo(env: Optional[Dict[str, str]]): pass ``` Reviewed By: highker Differential Revision: D81826386
kiukchung
force-pushed
the
export-D81826386
branch
from
ed6f82e to
1e59fac
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81826386 |
kiukchung
added a commit
that referenced
this pull request
Sep 9, 2025
…for optional types and builtin container types. (#1110) Summary: Pull Request resolved: #1110 For python-3.10, support type annotations in component fn arguments using builtin `dict`, `list`, `tuple` types and `|` for Optional types. Allows component fn to be typed as: ``` def foo(env: dict[str, str] | None): pass ``` versus ``` from typing import Dict, Optional def foo(env: Optional[Dict[str, str]]): pass ``` Reviewed By: highker Differential Revision: D81826386
kiukchung
force-pushed
the
export-D81826386
branch
from
1e59fac to
6f80df1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81826386 |
kiukchung
added a commit
that referenced
this pull request
Sep 9, 2025
…for optional types and builtin container types. (#1110) Summary: Pull Request resolved: #1110 For python-3.10, support type annotations in component fn arguments using builtin `dict`, `list`, `tuple` types and `|` for Optional types. Allows component fn to be typed as: ``` def foo(env: dict[str, str] | None): pass ``` versus ``` from typing import Dict, Optional def foo(env: Optional[Dict[str, str]]): pass ``` Reviewed By: highker Differential Revision: D81826386
kiukchung
force-pushed
the
export-D81826386
branch
from
6f80df1 to
f7db16c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81826386 |
kiukchung
added a commit
that referenced
this pull request
Sep 10, 2025
…for optional types and builtin container types. (#1110) Summary: Pull Request resolved: #1110 For python-3.10, support type annotations in component fn arguments using builtin `dict`, `list`, `tuple` types and `|` for Optional types. Allows component fn to be typed as: ``` def foo(env: dict[str, str] | None): pass ``` versus ``` from typing import Dict, Optional def foo(env: Optional[Dict[str, str]]): pass ``` Reviewed By: highker Differential Revision: D81826386
kiukchung
force-pushed
the
export-D81826386
branch
from
f7db16c to
71a840d
Compare
kiukchung
added a commit
that referenced
this pull request
Sep 10, 2025
…for optional types and builtin container types. (#1110) Summary: For python-3.10, support type annotations in component fn arguments using builtin `dict`, `list`, `tuple` types and `|` for Optional types. Allows component fn to be typed as: ``` def foo(env: dict[str, str] | None): pass ``` versus ``` from typing import Dict, Optional def foo(env: Optional[Dict[str, str]]): pass ``` Reviewed By: highker Differential Revision: D81826386
kiukchung
force-pushed
the
export-D81826386
branch
from
71a840d to
8d79d3a
Compare
kiukchung
added a commit
that referenced
this pull request
Sep 10, 2025
…for optional types and builtin container types. (#1110) Summary: For python-3.10, support type annotations in component fn arguments using builtin `dict`, `list`, `tuple` types and `|` for Optional types. Allows component fn to be typed as: ``` def foo(env: dict[str, str] | None): pass ``` versus ``` from typing import Dict, Optional def foo(env: Optional[Dict[str, str]]): pass ``` Reviewed By: highker Differential Revision: D81826386
kiukchung
force-pushed
the
export-D81826386
branch
from
8d79d3a to
a492880
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81826386 |
kiukchung
added a commit
that referenced
this pull request
Sep 10, 2025
…for optional types and builtin container types. (#1110) Summary: Pull Request resolved: #1110 For python-3.10, support type annotations in component fn arguments using builtin `dict`, `list`, `tuple` types and `|` for Optional types. Allows component fn to be typed as: ``` def foo(env: dict[str, str] | None): pass ``` versus ``` from typing import Dict, Optional def foo(env: Optional[Dict[str, str]]): pass ``` Reviewed By: highker Differential Revision: D81826386
kiukchung
force-pushed
the
export-D81826386
branch
from
a492880 to
5a5c561
Compare
…for optional types and builtin container types. (#1110) Summary: Pull Request resolved: #1110 For python-3.10, support type annotations in component fn arguments using builtin `dict`, `list`, `tuple` types and `|` for Optional types. Allows component fn to be typed as: ``` def foo(env: dict[str, str] | None): pass ``` versus ``` from typing import Dict, Optional def foo(env: Optional[Dict[str, str]]): pass ``` Reviewed By: highker Differential Revision: D81826386
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81826386 |
kiukchung
force-pushed
the
export-D81826386
branch
from
5a5c561 to
37ed313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For python-3.10, support type annotations in component fn arguments using builtin
dict,list,tupletypes and|for Optional types.Allows component fn to be typed as:
versus
Reviewed By: highker
Differential Revision: D81826386