(torchx/specs) Make torchx.specs.named_resources iterable #1163
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86984810. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
Summary: There's a bunch of use-cases where it is useful to be able to iterate over all the registered named resources. Implementing the `__iter__()` method makes this possible. NOTE: To keep the API consistent, the `_NamedResourcesLibrary.__iter__()` method materializes the resource objec by calling the factory function. This means that if you iterate over `named_resources` early in the program, you end up losing out on any lazy materialization. Reviewed By: AbishekS Differential Revision: D86984810
facebook-github-bot
force-pushed
the
export-D86984810
branch
2 times, most recently
from
f968b3d to
41cf3ec
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 91.63% 91.64% +0.01%
==========================================
Files 84 84
Lines 6595 6596 +1
==========================================
+ Hits 6043 6045 +2
+ Misses 552 551 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: There's a bunch of use-cases where it is useful to be able to iterate over all the registered named resources. Implementing the `__iter__()` method makes this possible. Reviewed By: AbishekS Differential Revision: D86984810
facebook-github-bot
force-pushed
the
export-D86984810
branch
from
41cf3ec to
6b6fda0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There's a bunch of use-cases where it is useful to be able to iterate over all the registered named resources. Implementing the
__iter__()method makes this possible.NOTE: To keep the API consistent, the
_NamedResourcesLibrary.__iter__()method materializes the resource objec by calling the factory function. This means that if you iterate overnamed_resourcesearly in the program, you end up losing out on any lazy materialization.Reviewed By: AbishekS
Differential Revision: D86984810