Skip to content

Commit 07088a7

Browse files
authored
[parser] Rename --iters to --rep (#359)
1 parent 901284a commit 07088a7

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

tritonbench/utils/parser.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import argparse
22

33
from tritonbench.utils.env_utils import AVAILABLE_PRECISIONS, is_fbcode
4-
from tritonbench.utils.triton_op import DEFAULT_RUN_ITERS, DEFAULT_WARMUP
4+
from tritonbench.utils.triton_op import DEFAULT_REP, DEFAULT_WARMUP
55

66

77
def get_parser(args=None):
@@ -52,13 +52,13 @@ def get_parser(args=None):
5252
"--warmup",
5353
type=int,
5454
default=DEFAULT_WARMUP,
55-
help="Num of warmup runs for reach benchmark run.",
55+
help="Num of warmup runs for each benchmark run.",
5656
)
5757
parser.add_argument(
58-
"--iter",
58+
"--rep",
5959
type=int,
60-
default=DEFAULT_RUN_ITERS,
61-
help="Num of reps for each benchmark run.",
60+
default=DEFAULT_REP,
61+
help="The rep time for each benchmark run.",
6262
)
6363
parser.add_argument(
6464
"--csv",

tritonbench/utils/triton_op.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class BenchmarkOperatorBackend:
7979

8080

8181
DEFAULT_WARMUP = 25
82-
DEFAULT_RUN_ITERS = 100
82+
DEFAULT_REP = 100
8383
DEFAULT_QUANTILES = [0.5, 0.1, 0.9]
8484
REGISTERED_BENCHMARKS: Dict[str, OrderedDict[str, BenchmarkOperatorBackend]] = {}
8585
REGISTERED_METRICS: defaultdict[str, List[str]] = defaultdict(list)
@@ -127,7 +127,7 @@ def __exit__(self, *args, **kwargs):
127127
self.elapsed_ms = (end_time - self._start_time) * 1e3
128128

129129

130-
def do_bench_walltime(fn, warmup=25, rep=100):
130+
def do_bench_walltime(fn, warmup=25, rep=DEFAULT_REP):
131131
fn()
132132
torch.cuda.synchronize()
133133

@@ -808,7 +808,7 @@ def fwd_no_grad_fn():
808808
return fwd_no_grad_fn
809809

810810
def run(
811-
self, warmup=DEFAULT_WARMUP, rep=DEFAULT_RUN_ITERS, quantiles=DEFAULT_QUANTILES
811+
self, warmup=DEFAULT_WARMUP, rep=DEFAULT_REP, quantiles=DEFAULT_QUANTILES
812812
) -> None:
813813
"""Benchmarking the operator and returning its metrics."""
814814
metrics = []
@@ -1183,7 +1183,7 @@ def _do_bench(
11831183
input_id: int,
11841184
fn_name: str,
11851185
warmup=DEFAULT_WARMUP,
1186-
rep=DEFAULT_RUN_ITERS,
1186+
rep=DEFAULT_REP,
11871187
quantiles=DEFAULT_QUANTILES,
11881188
baseline: bool = False,
11891189
) -> BenchmarkOperatorMetrics:

0 commit comments

Comments
 (0)