Skip to content

Commit 8540402

Browse files
FindHaofacebook-github-bot
authored andcommitted
Enhance CI workflow error messages for formatting and linting checks (#34)
Summary: Updated the GitHub Actions workflow to provide clearer error messages when formatting and linting checks fail. The new messages instruct users to run 'make format' to resolve issues and include a link to the detailed formatting guide. Key Changes: - Improved error handling in the format-check and lint-check jobs to guide users on fixing formatting issues. This change aims to enhance user experience by providing immediate feedback and resources for resolving code quality issues. Pull Request resolved: #34 Reviewed By: Sibylau Differential Revision: D78311326 Pulled By: FindHao fbshipit-source-id: 684f60d5464a1ee2a2bd27e819fd708d3633fbaa
1 parent b382256 commit 8540402

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ jobs:
5050
5151
- name: Check code formatting
5252
run: |
53-
make format-check
53+
make format-check || (echo "❌ Format check failed. Please run 'make format' to fix formatting issues, then commit the changes." && echo "📖 For detailed formatting guide, see: https://github.com/pytorch-labs/tritonparse/wiki/05.-Code-Formatting" && exit 1)
5454
5555
- name: Check linting
5656
run: |
57-
make lint-check || (echo "❌ Linting failed. Please run 'make format' to fix formatting issues, then commit the changes." && exit 1)
57+
make lint-check || (echo "❌ Linting failed. Please run 'make format' to fix formatting issues, then commit the changes." && echo "📖 For detailed formatting guide, see: https://github.com/pytorch-labs/tritonparse/wiki/05.-Code-Formatting" && exit 1)
5858
5959
test:
6060
runs-on: 4-core-ubuntu-gpu-t4

0 commit comments

Comments
 (0)