Skip to content

Commit c59857e

Browse files
FindHaometa-codesync[bot]
authored andcommitted
Fix oss_run missing procedure_checks parameter (#361)
Summary: Pull Request resolved: #361 `unified_parse()` passes `procedure_checks` to the underlying parse function, but `oss_run()` did not accept this parameter in its signature. This caused a `TypeError` in OSS/GitHub CI environments where `oss_run` is used instead of `fb_run`. Add `procedure_checks` parameter to `oss_run()` and forward it to `parse_logs()`. Reviewed By: prithvip0524, peiying779 Differential Revision: D97557615 fbshipit-source-id: e2bec2ea18322b7fec96bdc1c732bc1f176d56cd
1 parent 6e85c75 commit c59857e

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

tritonparse/parse/utils.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ def oss_run(
113113
split_inductor_compilations: bool = True,
114114
skip_logger: bool = True,
115115
torch_trace_dir: Optional[str] = None,
116+
procedure_checks: list = None,
116117
):
117118
"""
118119
Main function for tritonparse. It is for OSS only.
@@ -126,6 +127,8 @@ def oss_run(
126127
verbose: Verbose logging
127128
skip_logger: Unused in OSS, kept for API compatibility.
128129
torch_trace_dir: Path to directory containing inductor torch trace logs.
130+
procedure_checks: List of procedure check configurations for FileCheck-based
131+
pattern detection. If None, uses default patterns.
129132
"""
130133
source = Source(source, verbose)
131134
rank_config = RankConfig.from_cli_args(rank, all_ranks, source.type)
@@ -161,6 +164,7 @@ def oss_run(
161164
verbose,
162165
split_inductor_compilations=split_inductor_compilations,
163166
torch_trace_dir=torch_trace_dir,
167+
procedure_checks=procedure_checks,
164168
)
165169
else:
166170
parsed_log_dir = source.value

0 commit comments

Comments
 (0)