Skip to content

Commit d7401f8

Browse files
FindHaofacebook-github-bot
authored andcommitted
Fix File Diff URL Redirect (#116)
Summary: ## What Changed - Enhanced File Diff navigation to support direct URL access via `view=file_diff` parameter - Fixed active tab highlighting when navigating directly to File Diff view - Updated website version from 0.2.0 to 0.2.3 ## Files Modified - `website/src/App.tsx` - Added URL routing logic for File Diff view - `website/package.json` & `website/package-lock.json` - Version bump **Impact**: Users can now directly access and bookmark File Diff view URLs with proper tab state. Pull Request resolved: #116 Reviewed By: sfzhu93 Differential Revision: D82752237 Pulled By: FindHao fbshipit-source-id: 009c53074ccc2722b5ae2bf171f54bef93f7c4a4
1 parent dc28301 commit d7401f8

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

website/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

website/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "tritonparse-website",
33
"private": true,
4-
"version": "0.2.0",
4+
"version": "0.2.3",
55
"type": "module",
66
"scripts": {
77
"dev": "vite",

website/src/App.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,9 @@ function App() {
7070
const newUrl = new URL(window.location.href);
7171
newUrl.searchParams.set("json_url", jsonUrl);
7272
window.history.replaceState({}, "", newUrl.toString());
73+
} else if (view === "file_diff") {
74+
// Allow direct navigation to File Diff even without json_url
75+
setActiveTab("file_diff");
7376
}
7477

7578
// Check if fb directory exists and load internal utils if available
@@ -132,6 +135,8 @@ function App() {
132135
// Then, determine which view to show
133136
if (view === "ir_code_comparison") {
134137
setActiveTab("comparison");
138+
} else if (view === "file_diff") {
139+
setActiveTab("file_diff");
135140
}
136141

137142
setDataLoaded(true);
@@ -201,6 +206,8 @@ function App() {
201206
// Then, determine which view to show
202207
if (initialView === "ir_code_comparison") {
203208
setActiveTab("comparison");
209+
} else if (initialView === "file_diff") {
210+
setActiveTab("file_diff");
204211
}
205212
setDataLoaded(true);
206213
setLoadedUrl(url);
@@ -212,6 +219,8 @@ function App() {
212219
// Add view and kernel_hash parameters if applicable
213220
if (initialView === "ir_code_comparison") {
214221
newUrl.searchParams.set("view", "ir_code_comparison");
222+
} else if (initialView === "file_diff") {
223+
newUrl.searchParams.set("view", "file_diff");
215224
}
216225

217226
if (kernelHash) {

0 commit comments

Comments
 (0)