chore: Fixed ESLint warnings

Author: atharvsp02

src/client/entity-editor/common/entity-search-field-option.js

@@ -27,34 +27,14 @@ import SelectAsync from 'react-select/async';
 import ValidationLabel from '../common/validation-label';
 import _ from 'lodash';
 import {faQuestionCircle} from '@fortawesome/free-solid-svg-icons';
+import {RecentlyUsed} from '../../unified-form/common/recently-used';
 import {isValidBBID} from '../../../common/helpers/utils';
 import makeImmutable from './make-immutable';
 import request from 'superagent';
-import {RecentlyUsed} from '../../unified-form/common/recently-used';
-
 
 const ImmutableAsyncSelect = makeImmutable(SelectAsync);
 
 class EntitySearchFieldOption extends React.Component {
-	static entityTypeMappings = {
-		//Saving
-		'Author': 'authors',
-		'Edition': 'editions',
-		'EditionGroup': 'edition_groups',
-		'Publisher': 'publishers',
-		'Series': 'series',
-		'Work': 'works',
-		'Area': 'areas',
-		//Loading		
-		'authors': 'Author',
-		'editions': 'Edition',
-		'edition_groups' : 'EditionGroup',	
-		'publishers': 'Publisher',
-		'series': 'Series',
-		'works': 'Work',
-		'areas': 'Area'
-	};
-
 	constructor(props) {
 		super(props);
 		this.selectRef = React.createRef();
@@ -64,6 +44,25 @@ class EntitySearchFieldOption extends React.Component {
 		this.entityToOption = this.entityToOption.bind(this);
 	}
 
+	static entityTypeMappings = {
+		// Saving
+		Area: 'areas',
+		Author: 'authors',
+		Edition: 'editions',
+		EditionGroup: 'editiongroups',
+		Publisher: 'publishers',
+		Series: 'series',
+		Work: 'works',
+		// Loading
+		areas: 'Area',
+		authors: 'Author',
+		editiongroups: 'EditionGroup',
+		editions: 'Edition',
+		publishers: 'Publisher',
+		series: 'Series',
+		works: 'Work'
+	};
+
 	/**
 	 * Determines whether an entity provided to the EntitySearch component is an
 	 * Area, using the present attributes.
@@ -106,16 +105,15 @@ class EntitySearchFieldOption extends React.Component {
 		return entityOption;
 	}
 
-	getRecentlyUsedOptions(){
-		if(!this.props.recentlyUsedEntityType){
+	getRecentlyUsedOptions() {
+		if (!this.props.recentlyUsedEntityType) {
 			return [];
 		}
-		const entityTypes = Array.isArray(this.props.recentlyUsedEntityType)
-			? this.props.recentlyUsedEntityType : [this.props.recentlyUsedEntityType];
-		const validEntityTypes = entityTypes.filter(type => 
-			type && typeof type === 'string' && type.trim().length > 0
-		);
-		if(validEntityTypes.length === 0){
+		const entityTypes = Array.isArray(this.props.recentlyUsedEntityType) ?
+			this.props.recentlyUsedEntityType : [this.props.recentlyUsedEntityType];
+		const validEntityTypes = entityTypes.filter(type =>
+			type && typeof type === 'string' && type.trim().length > 0);
+		if (validEntityTypes.length === 0) {
 			return [];
 		}
 		const allRecentlyUsedItems = [];
@@ -130,24 +128,24 @@ class EntitySearchFieldOption extends React.Component {
 				});
 			}
 		});
-		if(allRecentlyUsedItems.length === 0){
+		if (allRecentlyUsedItems.length === 0) {
 			return [];
 		}
 		const uniqueItems = _.uniqBy(allRecentlyUsedItems, 'id').slice(0, 10);
 		return uniqueItems.map(item => {
 			const singularType = EntitySearchFieldOption.entityTypeMappings[item._sourceType] || item._sourceType.replace(/s$/, '');
 			return {
 				id: item.id,
-				text: item.name,
 				isRecentlyUsed: true,
+				text: item.name,
 				type: singularType
 			};
 		});
 	}
 
-	getDefaultOptions(){
+	getDefaultOptions() {
 		const recentOptions = this.getRecentlyUsedOptions();
-		if(recentOptions.length === 0){
+		if (recentOptions.length === 0) {
 			return true;
 		}
 		return [{
@@ -158,12 +156,11 @@ class EntitySearchFieldOption extends React.Component {
 
 	async fetchOptions(query) {
 		const recentOptions = this.getRecentlyUsedOptions();
-		const uniqueRecentOptions = _.uniqBy(recentOptions, 'id').slice(0, 10);	
+		const uniqueRecentOptions = _.uniqBy(recentOptions, 'id').slice(0, 10);
 		if (!query) {
 			if (uniqueRecentOptions.length === 0) {
 				return [];
 			}
-			
 			return [{
 				label: 'Recently Used',
 				options: uniqueRecentOptions
@@ -181,9 +178,8 @@ class EntitySearchFieldOption extends React.Component {
 			if (entity && typeof this.props.onChange === 'function' && (_.snakeCase(entity.type) === this.props.type ||
 				 (_.isArray(this.props.type) && this.props.type.includes(entity.type)))) {
 				const entityOption = this.entityToOption(entity);
-				if(entityOption.id && entityOption.text && entityOption.type){
+				if (entityOption.id && entityOption.text && entityOption.type) {
 					const storageKey = EntitySearchFieldOption.entityTypeMappings[entityOption.type] || `${entityOption.type.toLowerCase()}s`;
-					
 					RecentlyUsed.addItem(storageKey, {
 						id: entityOption.id,
 						name: entityOption.text
@@ -209,8 +205,8 @@ class EntitySearchFieldOption extends React.Component {
 		);
 		const filteredOptions = response.body.filter(combinedFilters);
 		const searchResults = filteredOptions.map(this.entityToOption);
-		if(uniqueRecentOptions.length > 0){
-			return[
+		if (uniqueRecentOptions.length > 0) {
+			return [
 				{
 					label: 'Recently Used',
 					options: uniqueRecentOptions
@@ -272,8 +268,8 @@ class EntitySearchFieldOption extends React.Component {
 		const wrappedSelect = (
 			<SelectWrapper
 				{...this.props}
-				cacheOptions
 				blurInputOnSelect
+				cacheOptions
 				isClearable
 				className={`Select${this.props.className ? ` ${this.props.className}` : ''}`}
 				classNamePrefix="react-select"
@@ -319,11 +315,11 @@ EntitySearchFieldOption.propTypes = {
 	isMulti: PropTypes.bool,
 	label: PropTypes.string,
 	languageOptions: PropTypes.array,
+	onChange: PropTypes.func.isRequired,
 	recentlyUsedEntityType: PropTypes.oneOfType([
 		PropTypes.string,
 		PropTypes.arrayOf(PropTypes.string)
 	]),
-	onChange: PropTypes.func.isRequired,
 	tooltipText: PropTypes.string,
 	type: PropTypes.oneOfType([
 		PropTypes.string,

src/client/entity-editor/edition-section/edition-section.tsx

@@ -241,7 +241,7 @@ function EditionSection({
 					}
 					type="editionGroup"
 					value={editionGroupValue}
-					recentlyUsedEntityType="edition_groups"
+					recentlyUsedEntityType="editiongroups"
 					onChange={onEditionGroupChange}
 					{...rest}
 				/>
@@ -520,7 +520,7 @@ function mapDispatchToProps(dispatch: Dispatch<Action>): DispatchProps {
 		)),
 		onEditionGroupChange: (value, action) => {
 			if(value && value.id && value.text){
-				RecentlyUsed.addItem('edition_groups', {
+				RecentlyUsed.addItem('editiongroups', {
 					id: value.id,
 					name: value.text
 				});