Merge pull request #3052 from zas/fix_dict_list_calls

Fix unnecessary dict() and list() calls

Author: zas

picard/acoustid/__init__.py

@@ -181,7 +181,7 @@ def _lookup_fingerprint(self, task, result=None, error=None):
             mparms,
             echo=None,
         )
-        params = dict(meta='recordings releasegroups releases tracks compress sources')
+        params = {'meta': 'recordings releasegroups releases tracks compress sources'}
         if result[0] == 'fingerprint':
             fp_type, fingerprint, length = result
             params['fingerprint'] = fingerprint

picard/acoustid/recordings.py

@@ -72,7 +72,7 @@ def __init__(self, ws: WebService, doc: dict, callback: callable) -> None:
         self._doc = doc
         self._callback = callback
         self._recording_map = defaultdict(dict)
-        self._recording_cache = dict()
+        self._recording_cache = {}
         self._missing_metadata = deque()
 
     def resolve(self) -> None:

picard/remotecommands/handlers.py

@@ -63,7 +63,7 @@
 )
 
 
-REMOTE_COMMANDS = dict()
+REMOTE_COMMANDS = {}
 
 
 class ParseItemsToLoad:

picard/track.py

@@ -96,7 +96,7 @@
 
 class TagGenreFilter:
     def __init__(self, filters):
-        self.errors = dict()
+        self.errors = {}
         self.match_regexes = defaultdict(list)
         for lineno, line in enumerate(filters.splitlines()):
             line = line.strip()

picard/ui/colors.py

@@ -153,7 +153,7 @@ def _config_key(self):
             return 'interface_colors'
 
     def set_default_colors(self):
-        self._colors = dict()
+        self._colors = {}
         for color_key in self.default_colors:
             self.set_default_color(color_key)
 

picard/ui/columns.py

@@ -150,8 +150,8 @@ def paint(self, painter, rect):
 
 class Columns(MutableSequence):
     def __init__(self, iterable=None, default_width=None):
-        self._list = list()
-        self._index = dict()
+        self._list = []
+        self._index = {}
         self._index_dirty = True
         self.status_icon_column = None
         self.default_width = default_width

picard/ui/mainwindow/actions.py

@@ -62,7 +62,7 @@
 from picard.ui.enums import MainAction
 
 
-_actions_functions = dict()
+_actions_functions = {}
 
 
 def add_action(action_name):

picard/util/imagelist.py

@@ -112,7 +112,7 @@ def hash_dict(self):
         return self._hash_dict
 
     def get_types_dict(self):
-        types_dict = dict()
+        types_dict = {}
         for image in self._images:
             image_types = image.normalized_types()
             if image_types in types_dict:

picard/util/settingsoverride.py

@@ -35,7 +35,7 @@ class SettingsOverride(MutableMapping):
 
     def __init__(self, orig_settings, *args, **kwargs):
         self.orig_settings = orig_settings
-        self._dict = dict()
+        self._dict = {}
         for k, v in dict(*args, **kwargs).items():
             self[k] = v