Skip to content

Commit 1807b46

Browse files
committed
Solve minor bug in NodeJS find script and trying to implement trampoline compatible for all build conditions.
1 parent e30c28e commit 1807b46

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

cmake/FindNodeJS.cmake

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@ set(NODEJS_PATHS
6363

6464
# Find NodeJS include directories
6565
if(MSVC OR CMAKE_BUILD_TYPE EQUAL "Debug")
66-
set(NODEJS_V8_HEADERS v8.h v8-debug.h v8-profiler.h v8stdint.h v8-version.h)
66+
set(NODEJS_V8_HEADERS v8.h v8-debug.h v8-profiler.h v8-version.h)
6767
else()
68-
set(NODEJS_V8_HEADERS v8.h v8stdint.h v8-version.h)
68+
set(NODEJS_V8_HEADERS v8.h v8-version.h)
6969
endif()
7070

7171
set(NODEJS_UV_HEADERS uv.h) # TODO: Add uv-(platform).h?
@@ -167,6 +167,7 @@ if(NODEJS_INCLUDE_DIR)
167167
foreach(HEADER IN ITEMS ${NODEJS_HEADERS})
168168
if(NOT EXISTS ${NODEJS_INCLUDE_DIR}/${HEADER})
169169
set(NODEJS_INCLUDE_DIR FALSE)
170+
break()
170171
endif()
171172
endforeach()
172173
endif()

source/loaders/node_loader/trampoline/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ if(MSVC)
6767

6868
add_dependencies(${target_binding} ${target})
6969
else()
70-
7170
if(OPTION_BUILD_GUIX)
7271
# Get the includes
7372
execute_process(
@@ -110,10 +109,9 @@ else()
110109
COMMAND ${CMAKE_COMMAND} -E copy_directory ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR}
111110
COMMAND npm install
112111
COMMAND node-gyp ${NODE_LOADER_TRAMPOLINE_BUILD_TYPE} rebuild --verbose
113-
COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_BINARY_DIR}/build/${CMAKE_BUILD_TYPE}/trampoline.so ${LOADER_LIBRARY_PATH}/trampoline.node
112+
COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_BINARY_DIR}/build/${CMAKE_BUILD_TYPE}/obj.target/trampoline.so ${LOADER_LIBRARY_PATH}/trampoline.node
114113
)
115114
endif()
116-
117115
endif()
118116

119117
#

0 commit comments

Comments
 (0)