Add previous check for ext_loader in order to detect before loading dynlink if the library exists.

Author: viferga

source/dynlink/include/dynlink/dynlink.h

@@ -145,6 +145,18 @@ DYNLINK_API void dynlink_unload(dynlink handle);
 */
 DYNLINK_API int dynlink_library_path(dynlink_name name, dynlink_library_path_str path, size_t *length);
 
+/**
+*  @brief
+*    Retrieve the library platform standard name by using @name as a base for it
+*
+*  @param[in] name
+*    Name of the library that will be used for generating the platform dependant library name (i.e example)
+*
+*  @param[out] result
+*    The resulting library name that will be generated (i.e libexample.so in Linux, or example.dll in Windows)
+*/
+DYNLINK_API void dynlink_platform_name(dynlink_name name, dynlink_name_impl result);
+
 /**
 *  @brief
 *    Provide the module information

source/dynlink/source/dynlink.c

@@ -163,6 +163,11 @@ int dynlink_library_path(dynlink_name name, dynlink_library_path_str path, size_
 	return 0;
 }
 
+void dynlink_platform_name(dynlink_name name, dynlink_name_impl result)
+{
+	dynlink_impl_get_name(name, result, PORTABILITY_PATH_SIZE);
+}
+
 const char *dynlink_print_info(void)
 {
 	static const char dynlink_info[] =

source/loaders/ext_loader/source/ext_loader_impl.cpp

@@ -30,6 +30,8 @@
 #include <reflect/reflect_scope.h>
 #include <reflect/reflect_type.h>
 
+#include <dynlink/dynlink.h>
+
 #include <log/log.h>
 
 #include <filesystem>
@@ -65,8 +67,9 @@ union loader_impl_function_cast
 	int (*fn)(void *, void *, void *);
 };
 
-dynlink ext_loader_impl_load_from_file_dynlink(loader_impl_ext ext_impl, const loader_path path);
-int ext_loader_impl_load_from_file_handle(loader_impl_ext ext_impl, loader_impl_ext_handle ext_handle, const loader_path path);
+static dynlink ext_loader_impl_load_from_file_dynlink(const char *path, const char *library_name);
+static dynlink ext_loader_impl_load_from_file_dynlink(loader_impl_ext ext_impl, const loader_path path);
+static int ext_loader_impl_load_from_file_handle(loader_impl_ext ext_impl, loader_impl_ext_handle ext_handle, const loader_path path);
 static void ext_loader_impl_destroy_handle(loader_impl_ext_handle ext_handle);
 
 int ext_loader_impl_initialize_types(loader_impl impl)
@@ -122,6 +125,26 @@ int ext_loader_impl_execution_path(loader_impl impl, const loader_path path)
 	return 0;
 }
 
+dynlink ext_loader_impl_load_from_file_dynlink(const char *path, const char *library_name)
+{
+	/* This function will try to check if the library exists before loading it,
+	so we avoid error messages from dynlink when guessing the file path for relative load from file */
+	dynlink_name_impl platform_name;
+
+	dynlink_platform_name(library_name, platform_name);
+
+	std::filesystem::path lib_path(path);
+
+	lib_path /= platform_name;
+
+	if (std::filesystem::exists(lib_path) == false)
+	{
+		return NULL;
+	}
+
+	return dynlink_load(path, library_name, DYNLINK_FLAGS_BIND_LAZY | DYNLINK_FLAGS_BIND_GLOBAL);
+}
+
 dynlink ext_loader_impl_load_from_file_dynlink(loader_impl_ext ext_impl, const loader_path path)
 {
 	std::string lib_path_str(path);
@@ -136,18 +159,14 @@ dynlink ext_loader_impl_load_from_file_dynlink(loader_impl_ext ext_impl, const l
 	if (lib_path.is_absolute())
 	{
 		std::filesystem::path lib_dir = lib_path.parent_path();
-		dynlink lib = dynlink_load(lib_dir.string().c_str(), lib_name.c_str(), DYNLINK_FLAGS_BIND_LAZY | DYNLINK_FLAGS_BIND_GLOBAL);
 
-		if (lib != NULL)
-		{
-			return lib;
-		}
+		return ext_loader_impl_load_from_file_dynlink(lib_dir.string().c_str(), lib_name.c_str());
 	}
 	else
 	{
 		for (auto exec_path : ext_impl->paths)
 		{
-			dynlink lib = dynlink_load(exec_path.string().c_str(), lib_name.c_str(), DYNLINK_FLAGS_BIND_LAZY | DYNLINK_FLAGS_BIND_GLOBAL);
+			dynlink lib = ext_loader_impl_load_from_file_dynlink(exec_path.string().c_str(), lib_name.c_str());
 
 			if (lib != NULL)
 			{