Skip to content

Commit 33a6f08

Browse files
committed
Minor bug solved in node port.
1 parent c4e64a0 commit 33a6f08

File tree

2 files changed

+5
-20
lines changed

2 files changed

+5
-20
lines changed

source/ports/node_port/source/node_port.cpp

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -196,16 +196,8 @@ void convertNodeArray_to_Metacall_Array(napi_env env, void *metacallArgs[], napi
196196
size_t _result;
197197
napi_get_value_string_utf8(env, element, string, GENERAL_STRING_LENGTH, &_result);
198198

199-
// checking if its a char(there is no char Javascript)
200-
if (_result == 1)
201-
{
202-
metacallArgs[i - 1] = metacall_value_create_char(string[0]);
203-
}
204-
else
205-
{
206-
// remember the for loop started from index 1 NOT 0.....
207-
metacallArgs[i - 1] = metacall_value_create_string(string, _result);
208-
}
199+
// remember the for loop started from index 1 NOT 0.....
200+
metacallArgs[i - 1] = metacall_value_create_string(string, _result);
209201

210202
break;
211203
case napi_number:
@@ -258,16 +250,8 @@ napi_value metacall_node(napi_env env, napi_callback_info info)
258250
size_t _result;
259251
napi_get_value_string_utf8(env, argv[i], string, 256, &_result);
260252

261-
// checking if its a char(there is no char Javascript)
262-
if (_result == 1)
263-
{
264-
metacallArgs[i - 1] = metacall_value_create_char(string[0]);
265-
}
266-
else
267-
{
268-
// remember the for loop started from index 1 NOT 0.....
269-
metacallArgs[i - 1] = metacall_value_create_string(string, _result);
270-
}
253+
// remember the for loop started from index 1 NOT 0.....
254+
metacallArgs[i - 1] = metacall_value_create_string(string, _result);
271255

272256
break;
273257
case napi_number:

source/ports/node_port/test/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ describe('metacall', () => {
4343
describe('call', () => {
4444
it('metacall (mock)', () => {
4545
assert.strictEqual(metacall('my_empty_func'), 1234);
46+
assert.strictEqual(metacall('three_str', 'a', 'b', 'c'), 'Hello World\u0000');
4647
});
4748
it('metacall (py)', () => {
4849
assert.strictEqual(metacall('multiply', 2, 2), 4);

0 commit comments

Comments
 (0)