Skip to content

Commit 3b370c6

Browse files
committed
Finished docker hub CI, remove warning from node loader.
1 parent 5c01e5b commit 3b370c6

File tree

2 files changed

+32
-14
lines changed

2 files changed

+32
-14
lines changed

.github/workflows/docker-hub.yml

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -27,22 +27,17 @@ env:
2727
# - linux/loong64
2828
PLATFORM_LIST: >
2929
[
30-
"linux/amd64"
30+
"linux/amd64",
31+
"linux/amd64/v2",
32+
"linux/amd64/v3",
33+
"linux/386",
34+
"linux/arm64",
35+
"linux/riscv64",
36+
"linux/ppc64le",
37+
"linux/arm/v7",
38+
"linux/arm/v6"
3139
]
3240
33-
34-
# [
35-
# "linux/amd64",
36-
# "linux/amd64/v2",
37-
# "linux/amd64/v3",
38-
# "linux/386",
39-
# "linux/arm64",
40-
# "linux/riscv64",
41-
# "linux/ppc64le",
42-
# "linux/arm/v7",
43-
# "linux/arm/v6"
44-
# ]
45-
4641
jobs:
4742
matrix:
4843
name: Generate Platform List

source/loaders/node_loader/source/node_loader_impl.cpp

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -919,11 +919,34 @@ static detour_handle node_module_handle_a_handle = NULL;
919919

920920
void node_loader_impl_register_linked_bindings()
921921
{
922+
/*
923+
* For now napi_module_register won't be deprecated: https://github.com/nodejs/node/issues/56153
924+
* If this changes, we can investigate the alternative approach.
925+
*/
926+
#if defined(_MSC_VER)
927+
#pragma warning(push)
928+
#pragma warning(disable : 4996)
929+
#elif defined(__clang__)
930+
#pragma clang diagnostic push
931+
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
932+
#elif defined(__GNUC__)
933+
#pragma GCC diagnostic push
934+
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
935+
#endif
936+
922937
/* Initialize Node Loader Trampoline */
923938
node_loader_impl_register_module("node_loader_trampoline_module", node_loader_trampoline_initialize);
924939

925940
/* Initialize Node Loader Port */
926941
node_loader_impl_register_module("node_loader_port_module", node_loader_port_initialize);
942+
943+
#if defined(_MSC_VER)
944+
#pragma warning(pop)
945+
#elif defined(__clang__)
946+
#pragma clang diagnostic pop
947+
#elif defined(__GNUC__)
948+
#pragma GCC diagnostic pop
949+
#endif
927950
}
928951

929952
void node_loader_impl_exception(napi_env env, napi_status status)

0 commit comments

Comments
 (0)