Remove warnings from rust loader, remove tests that break with sanitizers from rust, and change compile options in address sanitizer.

Author: viferga

.github/workflows/macos-test.yml

@@ -22,7 +22,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [macos-13, macos-14, macos-15]
+        os: [macos-14, macos-15-intel, macos-15]
         options: [
           {build: debug, sanitizer: without-sanitizer},
           {build: debug, sanitizer: address-sanitizer},

cmake/CompileOptions.cmake

@@ -131,14 +131,14 @@ elseif(OPTION_BUILD_ADDRESS_SANITIZER AND (CMAKE_BUILD_TYPE STREQUAL "Debug" OR
 		"LSAN_OPTIONS=verbosity=1:log_threads=1:print_suppressions=false:suppressions=${CMAKE_SOURCE_DIR}/source/tests/sanitizer/lsan.supp"
 
 		# Specify handle_segv=0 and detect_leaks=0 for the JVM (https://blog.gypsyengineer.com/en/security/running-java-with-addresssanitizer.html)
-		# "ASAN_OPTIONS=handle_segv=0:symbolize=1:alloc_dealloc_mismatch=0:strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1:fast_unwind_on_malloc=0"
+		# "ASAN_OPTIONS=handle_segv=0:symbolize=1:alloc_dealloc_mismatch=1:strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1:fast_unwind_on_malloc=0"
 
 		# TODO: We should document each flag why is it used, because now we do not know what runtime has each requirement and why.
 		# Another option should be to separate by runtimes and only set up them on the ASAN tests that require them,
 		# because we do not need to disable all features on all tests, this may hide bugs in the core library for example.
 
 		# Specify use_sigaltstack=0 as CoreCLR uses own alternate stack for signal handlers (https://github.com/swgillespie/coreclr/commit/bec020aa466d08e49e007d0011b0e79f8f7c7a62)
-		"ASAN_OPTIONS=use_sigaltstack=0:symbolize=1:alloc_dealloc_mismatch=0:strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1:fast_unwind_on_malloc=0"
+		"ASAN_OPTIONS=use_sigaltstack=0:symbolize=1:alloc_dealloc_mismatch=1:strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1:fast_unwind_on_malloc=0"
 	)
 	set(SANITIZER_COMPILE_DEFINITIONS
 		"__ADDRESS_SANITIZER__=1"

source/loaders/rs_loader/rust/compiler/src/lib.rs

@@ -1,10 +1,10 @@
 #![feature(rustc_private)]
 #![feature(once_cell)]
-// allow us to match on Box<T>s:
+// Allow us to match on Box<T>s:
 #![feature(box_patterns)]
 #![feature(let_else)]
 #![feature(iter_zip)]
-// allow us to get file prefix
+// Allow us to get file prefix
 #![feature(path_file_prefix)]
 extern crate rustc_ast;
 extern crate rustc_ast_pretty;
@@ -329,7 +329,7 @@ pub enum FunctionType {
     Ptr,
     Null,
     Complex,
-    This, // self in struct method
+    This, // Self in struct method
 }
 
 impl fmt::Display for FunctionType {
@@ -374,11 +374,11 @@ pub struct Attribute {
 pub struct Class {
     name: String,
     constructor: Option<Function>,
-    destructor: Option<Function>, // maybe we don't need destructor. just drop the variable
+    destructor: Option<Function>, // TODO: Maybe we don't need destructor, just drop the variable (review)
     methods: Vec<Function>,
     static_methods: Vec<Function>,
     attributes: Vec<Attribute>,
-    // static_attributes: Vec<Attribute>, // we don't handle static attrs in rust
+    // static_attributes: Vec<Attribute>, // We don't handle static attrs in rust
 }
 #[derive(Clone, Debug)]
 pub struct CompilerState {
@@ -430,28 +430,28 @@ impl CompilerCallbacks {
             .expect("Unable to get global ctxt")
             .peek_mut()
             .enter(|ctxt| {
-                // since we are loading a package, input_path should be lib<crate_name>.rlib
+                // Since we are loading a package, input_path should be lib<crate_name>.rlib
                 let crate_name = &self
                     .source
                     .input_path
                     .file_prefix()
                     .expect("Unable to get file prefix.")
                     .to_str()
                     .expect("Unable to cast OsStr to str")[3..];
-                // find our krate
+                // Find our crate
                 let crate_num = krates
                     .iter()
                     .find(|&&x| {
                         ctxt.crate_name(x) == rustc_span::Symbol::intern(crate_name)
                     })
                     .or_else(|| krates.iter().next())
                     .expect("unable to find crate");
-                // parse public functions and structs
+                // Parse public functions and structs
                 for child in ctxt.item_children(crate_num.as_def_id()) {
                     let Export {
                         ident, res, vis, ..
                     } = child;
-                    // skip non-public items
+                    // Skip non-public items
                     if !matches!(vis, Visibility::Public) {
                         continue;
                     }
@@ -499,7 +499,7 @@ impl CompilerCallbacks {
                         _ => {}
                     }
                 }
-                // after parsing all structs, parse tarit implementations.
+                // After parsing all structs, parse tarit implementations
                 for trait_impl in ctxt.all_trait_implementations(*crate_num) {
                     use rustc_middle::ty::fast_reject::SimplifiedTypeGen::AdtSimplifiedType;
                     if let Some(AdtSimplifiedType(def_id)) = trait_impl.1 {
@@ -710,7 +710,7 @@ impl<'a> visit::Visitor<'a> for ItemVisitor {
                     let name = item.ident.to_string();
                     match &item.kind {
                         rustc_ast::AssocItemKind::Fn(box rustc_ast::Fn { sig, .. }) => {
-                            // function has self in parameters
+                            // Function has self in parameters
                             if sig.decl.has_self() {
                                 match impl_kind {
                                     ImplKind::Drop => {
@@ -721,7 +721,7 @@ impl<'a> visit::Visitor<'a> for ItemVisitor {
                                     }
                                 }
                             } else {
-                                // static method
+                                // Static method
                                 match &sig.decl.output {
                                     rustc_ast::FnRetTy::Ty(p) => match &**p {
                                         rustc_ast::Ty { kind, .. } => match kind {

source/loaders/rs_loader/rust/compiler/src/wrapper/class.rs

@@ -1,3 +1,5 @@
+#![allow(dead_code)] // Disable warnings for unused code
+
 use std::any::*;
 use std::cell::Ref;
 use std::cell::RefCell;

source/ports/node_port/CMakeLists.txt

@@ -226,7 +226,7 @@ set(node_port_test_exec "${node_port_test}_executable")
 
 # TODO: Since MacOS 14 with ARM64, it does not support well NodeJS executable with preloaded sanitizers
 # The NodeJS initalization fails with: Node Loader failed to hook napi_register_module_v1
-if(APPLE)
+if(PROJECT_OS_FAMILY STREQUAL macos)
 	# Check if NodeJS is compiled with Address Sanitizer
 	if(OPTION_BUILD_ADDRESS_SANITIZER)
 		check_asan_executable("${NodeJS_EXECUTABLE}" NodeJS_ASAN)
@@ -246,6 +246,11 @@ if(APPLE)
 	endif()
 endif()
 
+# Address sanitizer does not work with Rust on Linux in NodeJS executable test
+if(PROJECT_OS_LINUX AND OPTION_BUILD_ADDRESS_SANITIZER AND OPTION_BUILD_LOADERS_RS)
+	set(TESTS_ENVIRONMENT_VARIABLES_RS)
+endif()
+
 message(STATUS "Test ${node_port_test_exec}")
 
 add_test(NAME ${node_port_test_exec}

source/tests/metacall_python_port_test/CMakeLists.txt

@@ -135,8 +135,8 @@ add_test(NAME ${target}
 	COMMAND $<TARGET_FILE:${target}>
 )
 
-# Enable rust test if it is built
-if(OPTION_BUILD_LOADERS_RS)
+# Enable rust test if it is built (address sanitizer does not work with Rust on Linux)
+if(OPTION_BUILD_LOADERS_RS AND NOT (OPTION_BUILD_ADDRESS_SANITIZER AND PROJECT_OS_LINUX))
 	set(RS_DEPENDENCY rs_loader)
 	set(TESTS_ENVIRONMENT_VARIABLES_RS "OPTION_BUILD_LOADERS_RS=1")
 endif()