Skip to content

Commit 79e5904

Browse files
committed
Add support for newer windows versions.
1 parent 6fb8de0 commit 79e5904

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

.github/workflows/benchmark.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ jobs:
9999
strategy:
100100
fail-fast: false
101101
matrix:
102-
os: [windows-2019, windows-2022, windows-2025]
102+
os: [windows-2022, windows-2025]
103103

104104
env:
105105
LTTNG_UST_REGISTER_TIMEOUT: 0

.github/workflows/windows-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
strategy:
2323
fail-fast: false
2424
matrix:
25-
os: [2019, 2022, 2025]
25+
os: [2022, 2025]
2626
options: [
2727
{build: debug, sanitizer: without-sanitizer},
2828
{build: debug, sanitizer: address-sanitizer},

cmake/FindNodeJS.cmake

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,9 @@ if(NOT NodeJS_LIBRARY)
453453
endif()
454454

455455
# Check for Visual Studio Version and configure the build command
456-
if(MSVC_VERSION GREATER 1916)
456+
if(MSVC_VERSION GREATER_EQUAL 1930)
457+
set(NodeJS_MSVC_VER vs2022)
458+
if(MSVC_VERSION GREATER_EQUAL 1920)
457459
set(NodeJS_MSVC_VER vs2019)
458460
elseif(MSVC_VERSION GREATER 1900)
459461
set(NodeJS_MSVC_VER vs2017)

docs/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -862,7 +862,8 @@ Where `script.js` is a script contained in host folder `$HOME/metacall` that wil
862862
| :-----------------: | :--------------------------------------------------: |
863863
| **`ubuntu-latest`** | https://metacall.github.io/core/bench/ubuntu-latest/ |
864864
| **`macos-latest`** | https://metacall.github.io/core/bench/macos-latest/ |
865-
| **`windows-2019`** | https://metacall.github.io/core/bench/windows-2019/ |
865+
| **`windows-2022`** | https://metacall.github.io/core/bench/windows-2022/ |
866+
| **`windows-2025`** | https://metacall.github.io/core/bench/windows-2025/ |
866867

867868
## 9. License
868869

0 commit comments

Comments
 (0)