Solve all issues in cs loader.

viferga · viferga · commit 85ecba341a6f · 2023-02-01T20:38:57.000+01:00
diff --git a/source/loaders/cs_loader/netcore/CMakeLists.txt b/source/loaders/cs_loader/netcore/CMakeLists.txt
@@ -63,24 +63,28 @@ if(OPTION_BUILD_GUIX)
 
 	# Build without internet access
 	add_custom_target(${target} ALL
+		COMMAND ${CMAKE_COMMAND} -E $<IF:$<VERSION_LESS:CMAKE_VERSION,3.17>,remove,rm> ${PROJECT_OUTPUT_DIR}/CSLoader.dll
 		COMMAND ${DOTNET_COMMAND} restore ${DOTNET_CORE_PATH_SOURCE} ${DOTNET_ADDITIONAL_PACKAGES_SOURCE} ${DOTNET_SOURCE} ${CMAKE_CURRENT_SOURCE_DIR}/source/project.csproj
 		COMMAND ${DOTNET_COMMAND} publish ${DOTNET_CORE_PATH_SOURCE} ${DOTNET_ADDITIONAL_PACKAGES_SOURCE} ${DOTNET_SOURCE} ${CMAKE_CURRENT_SOURCE_DIR}/source/project.csproj -o ${CMAKE_BINARY_DIR}
 	)
 else()
 	if(DOTNET_VERSION VERSION_EQUAL "2.0" OR DOTNET_VERSION VERSION_GREATER "2.0")
 		add_custom_target(${target} ALL
+			COMMAND ${CMAKE_COMMAND} -E $<IF:$<VERSION_LESS:CMAKE_VERSION,3.17>,remove,rm> ${PROJECT_OUTPUT_DIR}/CSLoader.dll
 			COMMAND ${DOTNET_ENV_VAR} ${DOTNET_COMMAND} restore ${CMAKE_CURRENT_SOURCE_DIR}/source/project.csproj
 			COMMAND ${DOTNET_ENV_VAR} ${DOTNET_COMMAND} publish ${CMAKE_CURRENT_SOURCE_DIR}/source/project.csproj -o ${PROJECT_OUTPUT_DIR}
 		)
 	else()
 		if(DOTNET_MIGRATE)
 			add_custom_target(${target} ALL
+				COMMAND ${CMAKE_COMMAND} -E $<IF:$<VERSION_LESS:CMAKE_VERSION,3.17>,remove,rm> ${PROJECT_OUTPUT_DIR}/CSLoader.dll
 				COMMAND ${DOTNET_ENV_VAR} ${DOTNET_COMMAND} migrate ${CMAKE_CURRENT_SOURCE_DIR}/source/project.json
 				COMMAND ${DOTNET_ENV_VAR} ${DOTNET_COMMAND} restore ${CMAKE_CURRENT_SOURCE_DIR}/source/project.json
 				COMMAND ${DOTNET_ENV_VAR} ${DOTNET_COMMAND} publish ${CMAKE_CURRENT_SOURCE_DIR}/source/project.json -o ${PROJECT_OUTPUT_DIR}
 			)
 		else()
 			add_custom_target(${target} ALL
+				COMMAND ${CMAKE_COMMAND} -E $<IF:$<VERSION_LESS:CMAKE_VERSION,3.17>,remove,rm> ${PROJECT_OUTPUT_DIR}/CSLoader.dll
 				COMMAND ${DOTNET_ENV_VAR} ${DOTNET_COMMAND} restore ${CMAKE_CURRENT_SOURCE_DIR}/source/project.json
 				COMMAND ${DOTNET_ENV_VAR} ${DOTNET_COMMAND} publish ${CMAKE_CURRENT_SOURCE_DIR}/source/project.json -o ${PROJECT_OUTPUT_DIR}
 			)
diff --git a/source/loaders/cs_loader/netcore/source/MetacallEntryPoint.cs b/source/loaders/cs_loader/netcore/source/MetacallEntryPoint.cs
@@ -7,7 +7,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using System.IO;
 using Microsoft.CodeAnalysis.Emit;
-using System.Runtime.Loader;
 using System.Runtime.InteropServices;
 using static CSLoader.MetacallDef;
 using System.Collections.Immutable;
diff --git a/source/loaders/cs_loader/netcore/source/Providers/LoaderBase.cs b/source/loaders/cs_loader/netcore/source/Providers/LoaderBase.cs
@@ -133,16 +133,24 @@ public bool LoadFromFileFunctions(string[] files)
             return LoadFromSourceFunctions(sources.ToArray());
         }
 
-        private void PrintDiagnostics(ImmutableArray<Diagnostic> diagnostics)
+        private int PrintDiagnostics(ImmutableArray<Diagnostic> diagnostics)
         {
-            IEnumerable<Diagnostic> failures = diagnostics.Where(diagnostic =>
-                diagnostic.IsWarningAsError ||
-                diagnostic.Severity == DiagnosticSeverity.Error);
+            int errorCount = 0;
 
-            foreach (Diagnostic diagnostic in failures)
+            foreach (Diagnostic diagnostic in diagnostics)
             {
-                this.log.Error("CSLoader compilation error: " + diagnostic.GetMessage());
+                if (diagnostic.IsWarningAsError || diagnostic.Severity == DiagnosticSeverity.Error)
+                {
+                    this.log.Error("CSLoader compilation error: " + diagnostic.ToString());
+                    ++errorCount;
+                }
+                else
+                {
+                    this.log.Error("CSLoader compilation warning: " + diagnostic.ToString());
+                }
             }
+
+            return errorCount;
         }
 
         public bool LoadFromSourceFunctions(string[] source)
@@ -185,21 +193,13 @@ public bool LoadFromSourceFunctions(string[] source)
                 )
             );
 
-            ImmutableArray<Diagnostic> compilationErrors = compilation.GetDiagnostics();
-
-            if (compilationErrors.Count() > 0)
+            if (PrintDiagnostics(compilation.GetDiagnostics()) > 0)
             {
-                PrintDiagnostics(compilationErrors);
-
                 return false;
             }
 
-            ImmutableArray<Diagnostic> declarationErrors = compilation.GetDeclarationDiagnostics();
-
-            if (compilationErrors.Count() > 0)
+            if (PrintDiagnostics(compilation.GetDeclarationDiagnostics()) > 0)
             {
-                PrintDiagnostics(declarationErrors);
-
                 return false;
             }
 
diff --git a/source/tests/metacall_cs_test/source/metacall_cs_test.cpp b/source/tests/metacall_cs_test/source/metacall_cs_test.cpp
@@ -86,7 +86,6 @@ TEST_F(metacall_cs_test, Concat)
 	metacall_value_destroy(ret);
 }
 
-#if !defined(__ADDRESS_SANITIZER__) /* TODO: C# Loader leaks when fails to load a script */
 TEST_F(metacall_cs_test, Fail)
 {
 	/* This is a Python script on purpose, in order to test C# when it fails */
@@ -99,7 +98,6 @@ TEST_F(metacall_cs_test, Fail)
 
 	EXPECT_EQ((int)1, (int)metacall_load_from_memory("cs", buffer, sizeof(buffer), NULL));
 }
-#endif
 
 TEST_F(metacall_cs_test, FailRelativePath)
 {
diff --git a/source/tests/sanitizer/lsan.supp b/source/tests/sanitizer/lsan.supp
@@ -34,6 +34,8 @@ leak:libruby*
 #
 leak:libcoreclr*
 leak:libicuuc*
+# TODO: Implement assembly unloading with loader context
+leak:System.Private.CoreLib.dll
 #
 # Rust
 #

Original file line number	Diff line number	Diff line change
`@@ -133,16 +133,24 @@ public bool LoadFromFileFunctions(string[] files)`
`133`	`133`	`return LoadFromSourceFunctions(sources.ToArray());`
`134`	`134`	`}`
`135`	`135`
`136`		`- private void PrintDiagnostics(ImmutableArray<Diagnostic> diagnostics)`
	`136`	`+ private int PrintDiagnostics(ImmutableArray<Diagnostic> diagnostics)`
`137`	`137`	`{`
`138`		`- IEnumerable<Diagnostic> failures = diagnostics.Where(diagnostic =>`
`139`		`- diagnostic.IsWarningAsError \|\|`
`140`		`- diagnostic.Severity == DiagnosticSeverity.Error);`
	`138`	`+ int errorCount = 0;`
`141`	`139`
`142`		`- foreach (Diagnostic diagnostic in failures)`
	`140`	`+ foreach (Diagnostic diagnostic in diagnostics)`
`143`	`141`	`{`
`144`		`- this.log.Error("CSLoader compilation error: " + diagnostic.GetMessage());`
	`142`	`+ if (diagnostic.IsWarningAsError \|\| diagnostic.Severity == DiagnosticSeverity.Error)`
	`143`	`+ {`
	`144`	`+ this.log.Error("CSLoader compilation error: " + diagnostic.ToString());`
	`145`	`+ ++errorCount;`
	`146`	`+ }`
	`147`	`+ else`
	`148`	`+ {`
	`149`	`+ this.log.Error("CSLoader compilation warning: " + diagnostic.ToString());`
	`150`	`+ }`
`145`	`151`	`}`
	`152`	`+`
	`153`	`+ return errorCount;`
`146`	`154`	`}`
`147`	`155`
`148`	`156`	`public bool LoadFromSourceFunctions(string[] source)`
`@@ -185,21 +193,13 @@ public bool LoadFromSourceFunctions(string[] source)`
`185`	`193`	`)`
`186`	`194`	`);`
`187`	`195`
`188`		`- ImmutableArray<Diagnostic> compilationErrors = compilation.GetDiagnostics();`
`189`		`-`
`190`		`- if (compilationErrors.Count() > 0)`
	`196`	`+ if (PrintDiagnostics(compilation.GetDiagnostics()) > 0)`
`191`	`197`	`{`
`192`		`- PrintDiagnostics(compilationErrors);`
`193`		`-`
`194`	`198`	`return false;`
`195`	`199`	`}`
`196`	`200`
`197`		`- ImmutableArray<Diagnostic> declarationErrors = compilation.GetDeclarationDiagnostics();`
`198`		`-`
`199`		`- if (compilationErrors.Count() > 0)`
	`201`	`+ if (PrintDiagnostics(compilation.GetDeclarationDiagnostics()) > 0)`
`200`	`202`	`{`
`201`		`- PrintDiagnostics(declarationErrors);`
`202`		`-`
`203`	`203`	`return false;`
`204`	`204`	`}`
`205`	`205`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,6 @@ TEST_F(metacall_cs_test, Concat)`
`86`	`86`	`metacall_value_destroy(ret);`
`87`	`87`	`}`
`88`	`88`
`89`		`-#if !defined(__ADDRESS_SANITIZER__) /* TODO: C# Loader leaks when fails to load a script */`
`90`	`89`	`TEST_F(metacall_cs_test, Fail)`
`91`	`90`	`{`
`92`	`91`	`/* This is a Python script on purpose, in order to test C# when it fails */`
`@@ -99,7 +98,6 @@ TEST_F(metacall_cs_test, Fail)`
`99`	`98`
`100`	`99`	`EXPECT_EQ((int)1, (int)metacall_load_from_memory("cs", buffer, sizeof(buffer), NULL));`
`101`	`100`	`}`
`102`		`-#endif`
`103`	`101`
`104`	`102`	`TEST_F(metacall_cs_test, FailRelativePath)`
`105`	`103`	`{`
Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,8 @@ leak:libruby*`
`34`	`34`	`#`
`35`	`35`	`leak:libcoreclr*`
`36`	`36`	`leak:libicuuc*`
	`37`	`+# TODO: Implement assembly unloading with loader context`
	`38`	`+leak:System.Private.CoreLib.dll`
`37`	`39`	`#`
`38`	`40`	`# Rust`
`39`	`41`	`#`