Add cross platform path improvements for C#.

Author: viferga

source/loaders/cs_loader/netcore/source/Providers/LoaderBase.cs

@@ -47,7 +47,7 @@ public bool LoadFromSourceFunctions(string[] source)
 
             MetadataReference[] references;
 
-            var mainPath = Path.GetDirectoryName(typeof(object).GetTypeInfo().Assembly.Location) + "/";
+            var mainPath = Path.GetDirectoryName(typeof(object).GetTypeInfo().Assembly.Location) + Path.DirectorySeparatorChar;
             var assemblyFiles = System.IO.Directory.GetFiles(mainPath, "*.dll");
 
             assemblyFiles = assemblyFiles.Concat(this.AdditionalLibs()).Distinct().ToArray();

source/loaders/cs_loader/netcore/source/Providers/LoaderV1.cs

@@ -24,7 +24,7 @@ private Assembly Context_Resolving(AssemblyLoadContext context, AssemblyName nam
 
                 try
                 {
-                    asm = context.LoadFromAssemblyPath(path + "\\" + name.Name + ".dll");
+                    asm = context.LoadFromAssemblyPath(Path.Combine(path, args.Name + ".dll"));
 
                     if (asm != null)
                     {

source/loaders/cs_loader/netcore/source/Providers/LoaderV2.cs

@@ -19,23 +19,19 @@ public LoaderV2(ILog log) : base(log)
         private Assembly AssemblyResolveEventHandler(object sender, ResolveEventArgs args)
         {
             Assembly asm = null;
-
-            this.log.Info("CSLoader resolving assembly " + args.Name);
+            AssemblyName assemName = args.RequestingAssembly.GetName();
 
             foreach (var path in paths)
             {
-                this.log.Info("CSLoader resolving path " + path);
-
                 try
                 {
-                    var fullPath = path + "\\" + args.Name + ".dll";
-
-                    this.log.Info(fullPath);
+                    var fullPath = Path.Combine(path, assemName.Name + ".dll");
 
                     asm = Assembly.LoadFile(fullPath);
 
                     if (asm != null)
                     {
+                        log.Info("Assembly loaded: " + fullPath);
                         return asm;
                     }
                     else
@@ -45,7 +41,7 @@ private Assembly AssemblyResolveEventHandler(object sender, ResolveEventArgs arg
                 }
                 catch (Exception ex)
                 {
-                    log.Error(string.Format("Exception when loading the Assembly {0}: {1}", args.Name, ex.Message), ex);
+                    log.Error(string.Format("Exception when loading the Assembly {0}: {1}", assemName.Name, ex.Message), ex);
                 }
             }
 
@@ -54,6 +50,16 @@ private Assembly AssemblyResolveEventHandler(object sender, ResolveEventArgs arg
 
         protected override IEnumerable<string> AdditionalLibs()
         {
+            /*
+            IEnumerable<string> libs = System.IO.Directory.GetFiles(AppDomain.CurrentDomain.BaseDirectory, "*.dll");
+
+            foreach (var path in paths)
+            {
+                libs = libs.Concat(System.IO.Directory.GetFiles(path, "*.dll"));
+            }
+
+            return libs; // TODO: Unique
+            */
             return System.IO.Directory.GetFiles(AppDomain.CurrentDomain.BaseDirectory, "*.dll");
         }