Improve FindNodeJS.cmake for NodeJS 14 (built as dll).

Author: viferga

cmake/FindNodeJS.cmake

@@ -390,10 +390,31 @@ if(NOT NodeJS_LIBRARY)
 					set(NodeJS_BUILD_TYPE release)
 				endif()
 
-				execute_process(COMMAND vcbuild.bat dll ${NodeJS_BUILD_TYPE} ${NodeJS_COMPILE_ARCH} ${NodeJS_MSVC_VER} WORKING_DIRECTORY "${NodeJS_OUTPUT_PATH}")
+				# Building NodeJS 14 as library in Windows is broken (so we need to patch it)
+				if(WIN32 AND NodeJS_VERSION_MAJOR GREATER_EQUAL 14)
+					set(Python_ADDITIONAL_VERSIONS 3)
+					find_package(PythonInterp REQUIRED)
+
+					execute_process(
+						COMMAND ${PYTHON_EXECUTABLE} ${CMAKE_SOURCE_DIR}/cmake/NodeJSGYPPatch.py ${NodeJS_OUTPUT_PATH}/node.gyp
+						WORKING_DIRECTORY "${NodeJS_OUTPUT_PATH}"
+						RESULT_VARIABLE NodeJS_PATCH_SCRIPT
+					)
+
+					if(NOT NodeJS_PATCH_SCRIPT EQUAL 0)
+						message(FATAL_ERROR "FindNodeJS.cmake failed to patch node.gyp project")
+					endif()
+				endif()
+
+				execute_process(
+					COMMAND vcbuild.bat dll ${NodeJS_BUILD_TYPE} ${NodeJS_COMPILE_ARCH} ${NodeJS_MSVC_VER}
+					WORKING_DIRECTORY "${NodeJS_OUTPUT_PATH}"
+					RESULT_VARIABLE NodeJS_BUILD_SCRIPT
+				)
 
-				# TODO: Implement msi build
-				# execute_process(COMMAND vcbuild.bat dll ${NodeJS_BUILD_TYPE} ${NodeJS_COMPILE_ARCH} ${NodeJS_MSVC_VER} msi WORKING_DIRECTORY "${NodeJS_OUTPUT_PATH}")
+				if(NOT NodeJS_BUILD_SCRIPT EQUAL 0)
+					message(FATAL_ERROR "FindNodeJS.cmake failed to build node library")
+				endif()
 
 				# Copy library to MetaCall output path
 				file(COPY ${NodeJS_OUTPUT_PATH}/${CMAKE_BUILD_TYPE}/node.dll DESTINATION ${CMAKE_BINARY_DIR}/${CMAKE_BUILD_TYPE}/node.dll)

cmake/NodeJSGYPPatch.py

@@ -0,0 +1,54 @@
+from sys import argv
+from os.path import isfile
+from shutil import copy2
+
+# Validate arguments
+if len(argv) != 2:
+	print('Invalid number of arguments, you should pass the location of \'node.gyp\'.')
+	print('Usage: python3 NodeJSGYPPatch.py <path_to_node_gyp>')
+	exit(1)
+
+# Validate the project file
+if not isfile(argv[1]) or not argv[1].endswith('node.gyp'):
+	print('The file \'' + argv[1] + '\' does not exist or is not a valid gyp file, it must be named as \'node.gyp\'.')
+	exit(2)
+
+# Read the file
+f = open(argv[1])
+nodegyp = eval(f.read())
+f.close()
+
+# Validate that the target is present and it is correct
+target = next((x for x in nodegyp['targets'] if 'target_name' in x and x['target_name'] == '<(node_lib_target_name)'), None)
+
+if target is None:
+	print('Invalid node.gyp configuration, the target \'node_lib_target_name\' is not present.')
+	exit(3)
+
+condition = next((x for x in target['conditions'] if x[0] == 'OS=="win"'), None)
+
+if condition is None or (condition is not None and len(condition) != 2):
+	print('Invalid node.gyp configuration, the condition \'OS=="win"\' is not present in target \'node_lib_target_name\'.')
+	exit(4)
+
+if not 'libraries' in condition[1]:
+	print('Invalid node.gyp configuration, \'libraries\' field is not present in the condition \'OS=="win"\' of the target target \'node_lib_target_name\'.')
+	exit(5)
+
+# Get the libraries
+libraries = condition[1]['libraries']
+
+# Check if the library to patch is present
+if not 'Winmm' in libraries:
+	# Copy file as backup
+	copy2(argv[1], argv[1] + '.backup')
+
+	# Apply the patch to the libraries
+	libraries.append('Winmm')
+
+	# Overwrite the node.gyp project
+	f = open(argv[1], 'w')
+	f.write(repr(nodegyp))
+	f.close()
+
+print('Build project node.gyp patched correctly')