Add throw exception on callbacks.

Author: viferga

source/loaders/node_loader/source/node_loader_impl.cpp

@@ -1062,6 +1062,11 @@ napi_value node_loader_impl_napi_to_value_callback(napi_env env, napi_callback_i
 
 	napi_value result = node_loader_impl_value_to_napi(closure_cast.safe->node_impl, env, ret);
 
+	if (value_type_id(ret) == TYPE_THROWABLE)
+	{
+		napi_throw(env, result);
+	}
+
 	/* Set result finalizer */
 	node_loader_impl_finalizer(env, result, ret);
 
@@ -1277,6 +1282,7 @@ napi_value node_loader_impl_value_to_napi(loader_impl_node node_impl, napi_env e
 
 		node_loader_impl_exception(env, status);
 
+		/* Passing code here seems not to work, instead set it once the error value has been created */
 		status = napi_create_error(env, label_value, message_value, &v);
 
 		node_loader_impl_exception(env, status);

source/loaders/node_loader/source/node_loader_port.cpp

@@ -227,6 +227,16 @@ napi_value node_loader_port_await(napi_env env, napi_callback_info info)
 	/* Await to the function */
 	void *ret = metacall_await_s(name, args, argc - 1, resolve, reject, ctx);
 
+	/* TODO: Is this needed? */
+	/*
+	if (metacall_value_id(ret) == METACALL_THROWABLE)
+	{
+		napi_value result = node_loader_impl_value_to_napi(node_impl, env, ret);
+
+		napi_throw(env, result);
+	}
+	*/
+
 	/* Release current reference of the environment */
 	// node_loader_impl_env(node_impl, NULL);
 

source/ports/node_port/test/index.js

@@ -103,6 +103,18 @@ describe('metacall', () => {
 
 			// TODO: Need a way to test the symbol is not globally defined.
 			//assert.strictEqual(metacall('py_memory_export'), undefined);
+
+
+			const handle_except = metacall_load_from_memory_export('py', 'def py_throw_error():\n\traise TypeError("yeet");\n');
+			assert.notStrictEqual(handle_except, undefined);
+			try {
+				handle_except.py_throw_error();
+				process.exit(1);
+			} catch (e) {
+				assert.strictEqual(e.message, 'yeet');
+				// TODO: For some reason, N-API fails to set the code properly, review it
+				// assert.strictEqual(e.code, 'TypeError');
+			}
 		});
 		// Cobol tests are conditional (in order to pass CI/CD)
 		if (process.env['OPTION_BUILD_LOADERS_COB']) {