Add move semantics and better information for exeptions in the node port.

Author: viferga

source/metacall/include/metacall/metacall_value.h

@@ -333,7 +333,7 @@ METACALL_API void metacall_value_own(void * v, void * owner);
 /**
 *  @brief
 *    Deep copies the value @v, the result copy resets
-*    the reference counter and ownership
+*    the reference counter and ownership, including the finalizer
 *
 *  @param[in] v
 *    Reference to the value to be copied
@@ -343,6 +343,19 @@ METACALL_API void metacall_value_own(void * v, void * owner);
 */
 METACALL_API void * metacall_value_copy(void * v);
 
+/**
+*  @brief
+*    Copies the ownership from @src to @dst, including the finalizer,
+*    and resets the owner and finalizer of @src
+*
+*  @param[in] src
+*    Source value which will lose the ownership
+*
+*  @param[in] dst
+*    Destination value which will recieve the ownership
+*/
+METACALL_API void metacall_value_move(void * src, void * dest);
+
 /**
 *  @brief
 *    Convert value @v to boolean

source/metacall/source/metacall_value.c

@@ -194,6 +194,11 @@ void * metacall_value_copy(void * v)
 	return value_type_copy(v);
 }
 
+void metacall_value_move(void * src, void * dst)
+{
+	value_move(src, dst);
+}
+
 boolean metacall_value_to_bool(void * v)
 {
 	assert(value_type_id(v) == TYPE_BOOL);

source/ports/node_port/source/node_port.cpp

@@ -289,7 +289,10 @@ inline void metacall_node_exception(napi_env env, napi_status status)
 			metacall_node_exception(env, status);
 
 			/* TODO: Notify MetaCall error handling system when it is implemented */
-			/* error_raise(str); */
+			/* Meanwhile, throw it again */
+			status = napi_throw_error(env, nullptr, str);
+
+			metacall_node_exception(env, status);
 
 			free(str);
 		}
@@ -694,7 +697,7 @@ napi_value metacall_node_value_to_napi(/* loader_impl_node node_impl,*/ napi_env
 		// Copy value and set the ownership, the old value will be deleted after the call
 		void * c = metacall_value_copy(arg_value);
 
-		metacall_value_own(c, metacall_value_owner(arg_value));
+		metacall_value_move(arg_value, c);
 
 		status = napi_create_external(env, c, nullptr, nullptr, &v);
 

source/reflect/include/reflect/reflect_value.h

@@ -86,6 +86,19 @@ REFLECT_API value value_create(const void * data, size_t bytes);
 */
 REFLECT_API value value_copy(value v);
 
+/**
+*  @brief
+*    Copies the ownership from @src to @dst, including the finalizer,
+*    and resets the owner and finalizer of @src
+*
+*  @param[in] src
+*    Source value which will lose the ownership
+*
+*  @param[in] dst
+*    Destination value which will recieve the ownership
+*/
+REFLECT_API void value_move(value src, value dst);
+
 /**
 *  @brief
 *    Returns the size of the value

source/reflect/source/reflect_value.c

@@ -116,6 +116,21 @@ value value_copy(value v)
 	return copy;
 }
 
+void value_move(value src, value dst)
+{
+	if (src != NULL && dst != NULL)
+	{
+		value_impl impl_src = value_descriptor(src);
+		value_impl impl_dst = value_descriptor(dst);
+
+		impl_dst->owner = impl_src->owner;
+		impl_dst->finalizer = impl_src->finalizer;
+
+		impl_src->owner = NULL;
+		impl_src->finalizer = NULL;
+	}
+}
+
 size_t value_size(value v)
 {
 	value_impl impl = value_descriptor(v);

source/scripts/python/function/source/function.py

@@ -47,3 +47,6 @@ def function_capsule_new_class():
 def function_capsule_method(klass):
 	print('Executing class method with instance passed as opaque pointer:', klass.f());
 	return klass.f();
+
+def function_capsule_cb(cb):
+	return cb(MyClass());