Skip to content

rust port: rename script to path for loading files #586

@fahdfady

Description

@fahdfady
pub fn from_memory(tag: impl ToString, script: impl ToString) -> Result<(), MetaCallLoaderError> {

this is from load module in rust port
using script here as a name for a parameter is cool.

problem

pub fn from_single_file(
    tag: impl ToString,
    script: impl AsRef<Path>,
pub fn from_file(
    tag: impl ToString,
    scripts: impl IntoIterator<Item = impl AsRef<Path>>,

here, I think it's a bit irrelevant. I Think we should rename it to something like "path" and "paths"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions