refactor: clean-up

[skip ci]

Author: metacosm

backend/src/main/java/net/laprun/sustainability/power/sensors/AbstractPowerSensor.java

@@ -100,7 +100,7 @@ public Set<String> getRegisteredPIDs() {
     @Override
     public Measures update(Long tick, Map<String, Double> cpuShares) {
         final long newUpdateStartEpoch = System.currentTimeMillis();
-        Log.infof("Sensor update for tick: %d, last called: %dms ago", tick, newUpdateStartEpoch - lastUpdateEpoch);
+        Log.debugf("Sensor update last called: %dms ago", newUpdateStartEpoch - lastUpdateEpoch);
         final var measures = doUpdate(lastUpdateEpoch, newUpdateStartEpoch, cpuShares);
         lastUpdateEpoch = newUpdateStartEpoch;
         return measures;

backend/src/main/java/net/laprun/sustainability/power/sensors/MapMeasures.java

@@ -3,7 +3,6 @@
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ConcurrentMap;
-import java.util.function.Consumer;
 
 import net.laprun.sustainability.power.SensorMeasure;
 
@@ -49,9 +48,4 @@ public void record(RegisteredPID pid, SensorMeasure sensorMeasure) {
     public SensorMeasure getOrDefault(RegisteredPID pid) {
         return measures.getOrDefault(pid, SensorMeasure.missing);
     }
-
-    @Override
-    public void forEach(Consumer<? super SensorMeasure> consumer) {
-        measures.keySet().forEach(pid -> consumer.accept(getOrDefault(pid)));
-    }
 }

backend/src/main/java/net/laprun/sustainability/power/sensors/Measures.java

@@ -1,7 +1,6 @@
 package net.laprun.sustainability.power.sensors;
 
 import java.util.Set;
-import java.util.function.Consumer;
 
 import net.laprun.sustainability.power.SensorMeasure;
 
@@ -63,9 +62,8 @@ public interface Measures {
      */
     SensorMeasure getOrDefault(RegisteredPID pid);
 
+    @SuppressWarnings("unused")
     default SensorMeasure getSystemTotal() {
         return getOrDefault(RegisteredPID.SYSTEM_TOTAL_REGISTERED_PID);
     }
-
-    void forEach(Consumer<? super SensorMeasure> consumer);
 }

backend/src/main/java/net/laprun/sustainability/power/sensors/linux/rapl/IntelRAPLSensor.java

@@ -58,6 +58,7 @@ private static SortedMap<String, RAPLFile> defaultRAPLFiles() {
         return files;
     }
 
+    @SuppressWarnings("NonAsciiCharacters")
     IntelRAPLSensor(SortedMap<String, RAPLFile> files) {
         if (files.isEmpty())
             throw new RuntimeException("Failed to get RAPL energy readings, probably due to lack of read access ");

backend/src/main/java/net/laprun/sustainability/power/sensors/macos/powermetrics/NuProcessWrapper.java

@@ -10,6 +10,7 @@ public class NuProcessWrapper implements ProcessWrapper {
     private PowermetricsProcessHandler measureHandler;
     private String periodInMilliSecondsAsString;
 
+    @SuppressWarnings("UnusedReturnValue")
     private NuProcess exec(PowermetricsProcessHandler handler) {
         if (handler == null)
             throw new IllegalArgumentException("Handler cannot be null");

backend/src/test/java/net/laprun/sustainability/power/sensors/linux/rapl/IntelRAPLSensorTest.java

@@ -132,6 +132,7 @@ void shouldIncludeCPUShareIfRequested() throws Exception {
         assertEquals(cpuShare, components[2]);
     }
 
+    @SuppressWarnings("SameParameterValue")
     private SensorMetadata loadMetadata(String... fileNames) {
         Class<? extends IntelRAPLSensorTest> clazz = getClass();
         final var files = Arrays.stream(fileNames)