match files to provides data based on exact match, not suffix

The files listed in provides data should be an exact match for the file
path we are using. The regex matching was added in
f3543c1 saying only "fixed regression".
I can barely guess at what it was supposedly fixing, but it was
definitely not the correct fix.

Author: haarg

lib/MetaCPAN/Model/Release.pm

@@ -481,15 +481,16 @@ sub _modules_from_meta {
 
     my $provides = $self->metadata->provides;
     my $files    = $self->files;
+    my %files    = map +( $_->path => $_ ), @$files;
     foreach my $module ( sort keys %$provides ) {
         my $data = $provides->{$module};
         my $path = File::Spec->canonpath( $data->{file} );
 
-        # Obey no_index and take the shortest path if multiple files match.
-        my ($file) = sort { length( $a->path ) <=> length( $b->path ) }
-            grep { $_->indexed && $_->path =~ /\Q$path\E$/ } @$files;
+        my $file = $files{$path}
+            or next;
+
+        next unless $file->indexed;
 
-        next unless $file;
         $file->add_module( {
             name    => $module,
             version => $data->{version},

t/lib/MetaCPAN/Tests/Release.pm

@@ -230,18 +230,14 @@ test 'modules in Packages-1.103' => sub {
         = map { ( $_->{path} => $_->{module} ) } @{ $self->module_files };
 
     foreach my $path ( sort keys %{ $self->modules } ) {
-        my $desc = "File '$path' has expected modules";
-        if ( my $got = delete $module_files{$path} ) {
-            my $got = [ map +{%$_}, @$got ];
-            $_->{associated_pod} //= undef for @$got;
+        my $desc        = "File '$path' has expected modules";
+        my $got_modules = delete $module_files{$path} || [];
+        my $got         = [ map +{%$_}, @$got_modules ];
+        $_->{associated_pod} //= undef for @$got;
 
      # We may need to sort modules by name, I'm not sure if order is reliable.
-            is_deeply $got, $self->modules->{$path}, $desc
-                or diag Test::More::explain($got);
-        }
-        else {
-            ok( 0, $desc );
-        }
+        is_deeply $got, $self->modules->{$path}, $desc
+            or diag Test::More::explain($got);
     }
 
     is( scalar keys %module_files, 0, 'all module files tested' )

t/release/file-duplicates.t

@@ -28,14 +28,7 @@ test_release(
                 indexed          => true,
                 associated_pod   => undef,
             } ],
-            'lib/Dupe.pm' => [ {
-                name             => 'Dupe',
-                version          => '0.993',
-                version_numified => '0.993',
-                authorized       => true,
-                indexed          => false,
-                associated_pod   => undef,
-            } ],
+            'lib/Dupe.pm'   => [],
             'DupeX/Dupe.pm' => [
                 {
                     name             => 'DupeX::Dupe',