Merge pull request #1303 from metacpan/haarg/tidy-critic-all

Apply critic and tidy to all files

Author: haarg

bin/check_json.pl

@@ -1,4 +1,7 @@
 #!/usr/bin/env perl
+use strict;
+use warnings;
+
 # This script is only needed if you are developing metacpan,
 # on the live servers we use File::Rsync::Mirror::Recent
 # https://github.com/metacpan/metacpan-puppet/tree/master/modules/rrrclient

bin/convert_authors.pl

@@ -1,64 +1,15 @@
 jobs = 5
 
 [PerlTidy]
-select = {bin,lib,t}/**/*.{pl,pm,t,psgi}
+select = {bin,lib,t,xt}/**/*.{pl,pm,t,psgi}
 select = bin/{metacpan,wait-for-open}
 select = app.psgi
 ignore = t/var/**/*
 argv = --profile=$ROOT/.perltidyrc
 
 [PerlCritic]
-select = {bin,lib,t}/**/*.{pl,pm,t,psgi}
+select = {bin,lib,t,xt}/**/*.{pl,pm,t,psgi}
 select = bin/{metacpan,wait-for-open}
-ignore = t/var/**/*
-ignore = bin/build_test_CPAN_dir.pl
-ignore = bin/check_json.pl
-ignore = bin/convert_authors.pl
-ignore = bin/get_fields.pl
-ignore = bin/mirror_cpan_for_developers.pl
-ignore = bin/unlisted_prereqs.pl
-ignore = bin/write_config_json
-ignore = lib/Catalyst/Action/Deserialize/MetaCPANSanitizedJSON.pm
-ignore = lib/Catalyst/Authentication/Store/Proxy.pm
-ignore = lib/Catalyst/Plugin/OAuth2/Provider.pm
-ignore = lib/Catalyst/Plugin/Session/Store/ElasticSearch.pm
-ignore = lib/MetaCPAN/Document/Distribution.pm
-ignore = lib/MetaCPAN/Document/File.pm
-ignore = lib/MetaCPAN/Document/Release.pm
-ignore = lib/MetaCPAN/Model.pm
-ignore = lib/MetaCPAN/Pod/XHTML.pm
-ignore = lib/MetaCPAN/Role/Common.pm
-ignore = lib/MetaCPAN/Script/Author.pm
-ignore = lib/MetaCPAN/Script/Backup.pm
-ignore = lib/MetaCPAN/Script/CPANTesters.pm
-ignore = lib/MetaCPAN/Script/Check.pm
-ignore = lib/MetaCPAN/Script/First.pm
-ignore = lib/MetaCPAN/Script/Latest.pm
-ignore = lib/MetaCPAN/Script/Mapping.pm
-ignore = lib/MetaCPAN/Script/Pagerank.pm
-ignore = lib/MetaCPAN/Script/PerlMongers.pm
-ignore = lib/MetaCPAN/Script/Query.pm
-ignore = lib/MetaCPAN/Script/ReindexDist.pm
-ignore = lib/MetaCPAN/Script/Release.pm
-ignore = lib/MetaCPAN/Script/Runner.pm
-ignore = lib/MetaCPAN/Script/Tickets.pm
-ignore = lib/MetaCPAN/Script/Watcher.pm
-ignore = lib/MetaCPAN/Server/Controller.pm
-ignore = lib/MetaCPAN/Server/Controller/Changes.pm
-ignore = lib/MetaCPAN/Server/Controller/File.pm
-ignore = lib/MetaCPAN/Server/Controller/Login.pm
-ignore = lib/MetaCPAN/Server/Controller/Login/PAUSE.pm
-ignore = lib/MetaCPAN/Server/Controller/Login/Twitter.pm
-ignore = lib/MetaCPAN/Server/Controller/Root.pm
-ignore = lib/MetaCPAN/Server/Controller/Search/Autocomplete.pm
-ignore = lib/MetaCPAN/Server/Controller/Source.pm
-ignore = lib/MetaCPAN/Server/Controller/User/Favorite.pm
-ignore = lib/MetaCPAN/Server/Model/CPAN.pm
-ignore = lib/MetaCPAN/Server/Model/Source.pm
-ignore = lib/MetaCPAN/Server/View/JSON.pm
-ignore = lib/MetaCPAN/Server/View/Pod.pm
-ignore = lib/MetaCPAN/Util.pm
-ignore = lib/Plack/Session/Store/ElasticSearch.pm
 
 [UniqueLines]
 select = .gitignore

bin/docker-elasticsearch

@@ -12,7 +12,7 @@ use Test::More;
 # Just use this to get an es object.
 my $server = MetaCPAN::TestServer->new;
 my $search = MetaCPAN::Query::Search->new(
-    es          => $server->es_client,
+    es         => $server->es_client,
     index_name => 'cpan',
 );