use code root, not checkout root

When searching for the root of the code, we don't actually want the
checkout root. In Docker, there won't actually be a checkout. Instead,
we just want the root directory. This can be calculated based on the
config module's path.

Author: haarg

cpanfile

@@ -58,7 +58,6 @@ requires 'File::stat';
 requires 'File::Temp';
 requires 'FindBin';
 requires 'Getopt::Long::Descriptive', '0.103';
-requires 'Git::Helpers', '1.000001';
 requires 'Gravatar::URL';
 requires 'Hash::Merge::Simple';
 requires 'HTML::Entities';

cpanfile.snapshot

@@ -229,14 +229,6 @@ DISTRIBUTIONS
     requirements:
       B 0
       ExtUtils::MakeMaker 0
-  Browser-Open-0.04
-    pathname: C/CF/CFRANKS/Browser-Open-0.04.tar.gz
-    provides:
-      Browser::Open 0.04
-    requirements:
-      ExtUtils::MakeMaker 0
-      Test::More 0.92
-      parent 0
   CGI-Simple-1.281
     pathname: M/MA/MANWAR/CGI-Simple-1.281.tar.gz
     provides:
@@ -2627,47 +2619,6 @@ DISTRIBUTIONS
       perl 5.012
       strict 0
       warnings 0
-  Git-Helpers-1.000001
-    pathname: O/OA/OALDERS/Git-Helpers-1.000001.tar.gz
-    provides:
-      Git::Helpers 1.000001
-      Git::Helpers::CPAN 1.000001
-    requirements:
-      Browser::Open 0
-      Capture::Tiny 0
-      Carp 0
-      ExtUtils::MakeMaker 0
-      File::pushd 0
-      Getopt::Long 0
-      Git::Sub 0
-      MetaCPAN::Client 2.029000
-      Moo 0
-      MooX::Options 0
-      Pod::Usage 0
-      String::Trim 0
-      Sub::Exporter 0
-      Term::Choose 1.743
-      Try::Tiny 0
-      Types::Standard 0
-      URI 0
-      URI::Heuristic 0
-      URI::git 0
-      perl v5.12.0
-      strict 0
-      warnings 0
-  Git-Sub-0.163320
-    pathname: D/DO/DOLMEN/Git-Sub-0.163320.tar.gz
-    provides:
-      Git::Sub 0.163320
-    requirements:
-      Carp 0
-      ExtUtils::MakeMaker 0
-      File::Which 0
-      System::Sub 0.162800
-      perl 5.006
-      strict 0
-      subs 0
-      warnings 0
   Gravatar-URL-1.07
     pathname: M/MS/MSCHWERN/Gravatar-URL-1.07.tar.gz
     provides:
@@ -6676,18 +6627,6 @@ DISTRIBUTIONS
       perl 5.012
       strict 0
       warnings 0
-  String-Trim-0.005
-    pathname: D/DO/DOHERTY/String-Trim-0.005.tar.gz
-    provides:
-      String::Trim 0.005
-    requirements:
-      Data::Dumper 0
-      Exporter 5.57
-      ExtUtils::MakeMaker 6.31
-      File::Find 0
-      File::Temp 0
-      Test::Builder 0.94
-      Test::More 0.94
   Sub-Exporter-0.991
     pathname: R/RJ/RJBS/Sub-Exporter-0.991.tar.gz
     provides:
@@ -6811,23 +6750,6 @@ DISTRIBUTIONS
     requirements:
       Call::Context 0
       ExtUtils::MakeMaker 0
-  System-Sub-0.162800
-    pathname: D/DO/DOLMEN/System-Sub-0.162800.tar.gz
-    provides:
-      System::Sub 0.162800
-      System::Sub::AutoLoad 0.162800
-    requirements:
-      Carp 0
-      ExtUtils::MakeMaker 0
-      File::Which 0
-      IPC::Run 0
-      Scalar::Util 1.11
-      Sub::Name 0
-      Symbol 0
-      constant 0
-      perl 5.006
-      strict 0
-      warnings 0
   TOML-Tiny-0.18
     pathname: O/OA/OALDERS/TOML-Tiny-0.18.tar.gz
     provides:
@@ -6856,34 +6778,6 @@ DISTRIBUTIONS
       Scalar::Util 1.14
       perl 5.006
       strict 0
-  Term-Choose-1.765
-    pathname: K/KU/KUERBIS/Term-Choose-1.765.tar.gz
-    provides:
-      Term::Choose 1.765
-      Term::Choose::Constants 1.765
-      Term::Choose::LineFold 1.765
-      Term::Choose::LineFold::CharWidthAmbiguousWide 1.765
-      Term::Choose::LineFold::CharWidthDefault 1.765
-      Term::Choose::Linux 1.765
-      Term::Choose::Opt::Mouse 1.765
-      Term::Choose::Opt::Search 1.765
-      Term::Choose::Opt::SkipItems 1.765
-      Term::Choose::Screen 1.765
-      Term::Choose::ValidateOptions 1.765
-      Term::Choose::Win32 1.765
-    requirements:
-      Carp 0
-      Exporter 0
-      ExtUtils::MakeMaker 0
-      File::Spec::Functions 0
-      FindBin 0
-      Test::Fatal 0
-      Test::More 0
-      constant 0
-      lib 0
-      perl 5.010000
-      strict 0
-      warnings 0
   Term-Size-Any-0.002
     pathname: F/FE/FERREIRA/Term-Size-Any-0.002.tar.gz
     provides:
@@ -7962,15 +7856,6 @@ DISTRIBUTIONS
       URI 1.40
       URI::Nested 0.10
       perl 5.008001
-  URI-git-0.02
-    pathname: M/MI/MIYAGAWA/URI-git-0.02.tar.gz
-    provides:
-      URI::git 0.02
-    requirements:
-      ExtUtils::MakeMaker 6.42
-      Filter::Util::Call 0
-      Test::More 0
-      URI 0
   URI-ws-0.03
     pathname: P/PL/PLICEASE/URI-ws-0.03.tar.gz
     provides:

lib/MetaCPAN/Role/HasConfig.pm

@@ -4,7 +4,6 @@ use Moose::Role;
 
 use MetaCPAN::Server::Config  ();
 use MetaCPAN::Types::TypeTiny qw( HashRef );
-use MetaCPAN::Util            qw( checkout_root );
 
 # Done like this so can be required by a role
 sub config {

lib/MetaCPAN/Role/Script.pm

@@ -9,7 +9,7 @@ use IO::Prompt::Tiny                       qw( prompt );
 use Log::Contextual                        qw( :log :dlog );
 use MetaCPAN::Model                        ();
 use MetaCPAN::Types::TypeTiny              qw( Bool HashRef Int Path Str );
-use MetaCPAN::Util                         qw( checkout_root );
+use MetaCPAN::Util                         qw( root_dir );
 use Mojo::Server                           ();
 use Term::ANSIColor                        qw( colored );
 
@@ -123,7 +123,7 @@ has home => (
     isa     => Path,
     lazy    => 1,
     coerce  => 1,
-    default => sub { checkout_root() },
+    default => sub { root_dir() },
 );
 
 has quarantine => (

lib/MetaCPAN/Server/Config.pm

@@ -3,20 +3,15 @@ package MetaCPAN::Server::Config;
 use warnings;
 use strict;
 
-use Config::ZOMG    ();
-use FindBin         ();
-use Module::Runtime qw( require_module );
+use Config::ZOMG   ();
+use MetaCPAN::Util qw(root_dir);
 
 sub config {
-    my $config = _zomg("$FindBin::RealBin/..");
-    return $config if $config;
-
-    require_module('Git::Helpers');
-    $config = _zomg( Git::Helpers::checkout_root() );
+    my $root   = root_dir();
+    my $config = _zomg($root);
 
     if ( !$config ) {
-        die "Couldn't find config file in $FindBin::RealBin/.. or "
-            . Git::Helpers::checkout_root();
+        die "Couldn't find config file in $root";
     }
 
     return $config;

lib/MetaCPAN/Util.pm

@@ -6,10 +6,12 @@ use strict;
 use warnings;
 use version;
 
-use Digest::SHA qw( sha1_base64 sha1_hex );
-use Encode      qw( decode_utf8 );
-use IPC::Run3   ();
-use Ref::Util   qw(
+use Cwd            ();
+use Digest::SHA    qw( sha1_base64 sha1_hex );
+use Encode         qw( decode_utf8 );
+use File::Basename ();
+use File::Spec     ();
+use Ref::Util      qw(
     is_arrayref
     is_hashref
     is_plain_arrayref
@@ -19,7 +21,7 @@ use Ref::Util   qw(
 use Cpanel::JSON::XS ();
 use Sub::Exporter -setup => {
     exports => [ qw(
-        checkout_root
+        root_dir
         author_dir
         diff_struct
         digest
@@ -41,17 +43,13 @@ use Sub::Exporter -setup => {
 *false   = \&Cpanel::JSON::XS::false;
 *is_bool = \&Cpanel::JSON::XS::is_bool;
 
-sub checkout_root {
-    IPC::Run3::run3( [qw(git rev-parse --show-toplevel)],
-        \undef, \my $stdout, \my $stderr );
-    if ($?) {
-        die $stderr;
-    }
-    chomp $stdout;
-    if ( !-d $stdout ) {
-        die "Failed to find git dir: '$stdout'";
-    }
-    return $stdout;
+sub root_dir {
+    Cwd::abs_path(
+        File::Spec->catdir(
+            File::Basename::dirname(__FILE__),
+            ( File::Spec->updir ) x 2
+        )
+    );
 }
 
 sub digest {

t/lib/MetaCPAN/TestHelpers.pm

@@ -10,7 +10,7 @@ use Cpanel::JSON::XS         qw( decode_json encode_json );
 use File::Copy               qw( copy );
 use File::pushd              qw( pushd );
 use MetaCPAN::Server::Config ();
-use MetaCPAN::Util           qw( checkout_root );
+use MetaCPAN::Util           qw( root_dir );
 use Path::Tiny               qw( path );
 use Test::More;
 use Test::Routine::Util qw( run_tests );
@@ -103,7 +103,7 @@ sub get_config {
 }
 
 sub tmp_dir {
-    my $dir = path( checkout_root(), 'var', 't', 'tmp' );
+    my $dir = path( root_dir(), 'var', 't', 'tmp' );
     $dir->mkpath;
     return $dir;
 }
@@ -116,7 +116,7 @@ sub fakecpan_dir {
 }
 
 sub fakecpan_configs_dir {
-    my $source = path( checkout_root(), 'test-data', 'fakecpan' );
+    my $source = path( root_dir(), 'test-data', 'fakecpan' );
     $source->mkpath;
     return $source;
 }

t/script/cover.t

@@ -5,11 +5,11 @@ use lib 't/lib';
 
 use MetaCPAN::Script::Cover  ();
 use MetaCPAN::Server::Config ();
-use MetaCPAN::Util           qw( checkout_root );
+use MetaCPAN::Util           qw( root_dir );
 use Test::More;
 use URI ();
 
-my $root = checkout_root();
+my $root = root_dir();
 my $file = URI->new('t/var/cover.json')->abs("file://$root/");
 
 my $config = MetaCPAN::Server::Config::config();

t/script/river.t

@@ -5,15 +5,15 @@ use lib 't/lib';
 use MetaCPAN::Script::River ();
 use MetaCPAN::Server::Test  qw( app GET );
 use MetaCPAN::TestHelpers   qw( decode_json_ok );
-use MetaCPAN::Util          qw( checkout_root );
+use MetaCPAN::Util          qw( root_dir );
 use Plack::Test             ();
 use Test::More;
 use URI ();
 
 my $config = MetaCPAN::Server::Config::config();
 
 # local json file with structure from https://github.com/metacpan/metacpan-api/issues/460
-my $root = checkout_root();
+my $root = root_dir();
 my $file = URI->new('t/var/river.json')->abs("file://$root/");
 $config->{'river_url'} = "$file";