normalize pagination parameters and add size limits #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always accept page and page_size parameters, and pass them around internally in that order. Some end points were accepting size rather than page_size. Support both parameters for these, prioritizing page_size. The search end points were accepting a from parameter rather than page. Add support for a page parameter, and convert the from param into the page as a fallback.
mickeyn
previously approved these changes
Nov 5, 2024
Paged results are expensive to compute on Elasticsearch. It will refuse to give results if paged forward far enough. Limit our pagination and give empty results if paged too deep.
haarg
force-pushed
the
haarg/normalize-limit-pagination
branch
from
4814f61 to
453f770
Compare
mickeyn
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize pagination to use
pageandpage_sizeparameters rather than sometimesfromorsize.Add limits to 10000 max results, returning early rather than sending queries to Elasticsearch.