Favourites list on author page is silently truncated

[openstrike]

On the author page, the list of favourites by that author seems to stop at 242 entries.

To Reproduce:

1. Go to https://metacpan.org/author/SYP
2. Scroll down to the bottom
3. See the last item on the list to be JSON-PP
4. Then check eg. https://metacpan.org/dist/Test-Mojibake and see that SYP has favourited this one (and apparently many more) which isn't listed on the author page

Expected behaviour
Either all of the favourites should be shown or there should be some indication that only the first N are shown.

Additional context
This is only really apparent when the list obviously ends in the middle, as it does for SYP who has so many. If it only skips the last couple that would be even more non-obvious.

[manwar]

This has been patched in this pull request:
#3337

[openstrike]

Thanks, but doesn't this just move the limit to 500 rather than eradicate it entirely? What happens when some user has 550 favourites?

If there has to be a limit (and it's fair if there does) then the list should advise that it is capped. Alternatively, the user should not be allowed to favourite more than $FAV_MAX, whatever that value may be.

[oalders]

This is a stop gap. It doesn't fix the problem entirely but it allows us to kick the can down the road while we focus on more pressing issues. 😀