Add a placeholder ./local dir #3334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exists so that this mapping doesn't prevent "docker compose up"
from running:
web-server:
volumes:
- '/app/local'
The purpose of this is to prevent an existing ./local from being mapped
into the container, since there could well be a mismatch between the
locally installed perl used for ./local and the perl which is available
in the container.
haarg
approved these changes
May 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3334 +/- ##
==========================================
+ Coverage 73.48% 73.56% +0.08%
==========================================
Files 68 68
Lines 2387 2387
Branches 335 335
==========================================
+ Hits 1754 1756 +2
+ Misses 507 506 -1
+ Partials 126 125 -1 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exists so that this mapping doesn't prevent "docker compose up"
from running:
web-server:
volumes:
- '/app/local'
The purpose of this is to prevent an existing ./local from being mapped
into the container, since there could well be a mismatch between the
locally installed perl used for ./local and the perl which is available
in the container.