Skip to content

Commit 13da9ef

Browse files
committed
AI: pm iteration cap
1 parent 596ace6 commit 13da9ef

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

agents.just

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@ questions-for-pm workspace_id rev='@': (run workspace_id "questions-for-pm" "que
5858

5959
questions-for-pm-inner rev='@':
6060
#!/usr/bin/env sh
61-
CURRENT_CHANGE=`jj log -r @ --template 'change_id' --no-graph`
62-
echo BBBB: `pwd`
63-
6461
read -r -d '' INSTRUCTIONS_1 <<-EOF
6562
1. Read the current state of open issues in issues.md
6663
2. Read relevant state of the code base
@@ -80,9 +77,24 @@ questions-for-pm-inner rev='@':
8077

8178
# Initialize iteration counter for commit messages
8279
ITERATION=1
80+
ITERATION_CAP_RAW="${ITERATION_CAP:-0}"
81+
ITERATION_CAP_VALUE=0
82+
case "$ITERATION_CAP_RAW" in
83+
''|*[!0-9]*)
84+
echo "ITERATION_CAP must be a non-negative integer; got '$ITERATION_CAP_RAW'" >&2
85+
exit 1
86+
;;
87+
*)
88+
ITERATION_CAP_VALUE="$ITERATION_CAP_RAW"
89+
;;
90+
esac
8391

8492
# Keep asking until no further changes are made to pm-faq.md
8593
while true; do
94+
if [ "$ITERATION_CAP_VALUE" -ne 0 ] && [ "$ITERATION" -gt "$ITERATION_CAP_VALUE" ]; then
95+
echo "Reached iteration cap (${ITERATION_CAP_VALUE}); stopping questions-for-pm loop." >&2
96+
break
97+
fi
8698
PREV_HASH=`[ -f pm-faq.md ] && sha256sum pm-faq.md | cut -d' ' -f1 || echo ""`
8799

88100
echo "$INSTRUCTIONS_1" | {{codex}}
@@ -91,7 +103,7 @@ questions-for-pm-inner rev='@':
91103
[ "$CURR_HASH" = "$PREV_HASH" ] && break
92104

93105
# Optional manual edits
94-
jj edit $CURRENT_CHANGE && {{workspace_just}} edit-inner $PM_CHANGE
106+
{{workspace_just}} edit-inner $PM_CHANGE
95107
# Update issues based on PM responses
96108
{{workspace_just}} pm-flow-update-inner $PM_CHANGE
97109

@@ -104,9 +116,6 @@ questions-for-pm-inner rev='@':
104116
# Abandon the last PM_CHANGE since it must have been empty
105117
jj abandon $PM_CHANGE
106118

107-
# Return to original change
108-
jj edit $CURRENT_CHANGE
109-
110119

111120
pm-flow-update workspace_id rev='@': (run workspace_id "pm-flow-update" "pm-flow-update-inner" rev)
112121

0 commit comments

Comments
 (0)