Milestone 6 - wrap-up

Author: tzanko-matev

.envrc

@@ -1,3 +1,6 @@
 watch_file nix/flake.nix
 watch_file nix/flake.lock
+watch_file .venv/pyvenv.cfg
 use flake ./nix
+
+. .venv/bin/activate

codetracer-python-recorder/src/monitoring/callbacks.rs

@@ -7,7 +7,7 @@ use crate::code_object::{CodeObjectRegistry, CodeObjectWrapper};
 use crate::ffi;
 use crate::logging;
 use crate::policy::{self, OnRecorderError};
-use log::{error, warn};
+use log::{error, trace, warn};
 use pyo3::prelude::*;
 use pyo3::types::{PyAny, PyCode, PyModule};
 use pyo3::wrap_pyfunction;
@@ -486,7 +486,6 @@ type CallbackFactory = for<'py> fn(&Bound<'py, PyModule>) -> PyResult<CallbackFn
 /// Metadata describing how to register a sys.monitoring callback.
 pub struct CallbackSpec {
     /// Debug label (mirrors the PyO3 function name).
-    #[allow(dead_code)]
     pub name: &'static str,
     event: fn(&MonitoringEvents) -> EventId,
     factory: CallbackFactory,
@@ -598,6 +597,11 @@ pub fn register_enabled_callbacks<'py>(
 ) -> PyResult<()> {
     for spec in enabled_specs(mask, events) {
         let event = spec.event(events);
+        trace!(
+            "[monitoring] registering callback `{}` for event id {}",
+            spec.name,
+            event.0
+        );
         let cb = spec.make(module)?;
         register_callback(py, tool, &event, Some(&cb))?;
     }
@@ -613,6 +617,11 @@ pub fn unregister_enabled_callbacks(
 ) -> PyResult<()> {
     for spec in enabled_specs(mask, events) {
         let event = spec.event(events);
+        trace!(
+            "[monitoring] unregistering callback `{}` for event id {}",
+            spec.name,
+            event.0
+        );
         register_callback(py, tool, &event, None)?;
     }
     Ok(())

design-docs/adr/0011-codetracer-architecture-refactor.md

@@ -1,6 +1,6 @@
 # ADR 0011: Codetracer Python Recorder Architecture Refactor
 
-- **Status:** Accepted _(incremental rollout in progress — Milestone 4 complete)_
+- **Status:** Accepted
 - **Date:** 2025-02-14
 - **Deciders:** codetracer recorder maintainers
 - **Consulted:** DX tooling crew, Runtime tracing stakeholders
@@ -68,5 +68,5 @@ We will modularise the recorder around cohesive responsibilities while preservin
 1. Land the modularisation in staged PRs following the implementation plan, keeping behavioural changes isolated per milestone.  
 2. Maintain compatibility with current Python APIs and crate exports; adjust import paths gradually with deprecation windows if needed.  
 3. Update architectural documentation and developer guides once core milestones complete.  
-4. **Status snapshot (2025‑03‑01):** Milestones 1–4 (trace filter, policy/logging, session bootstrap, monitoring plumbing) are complete and validated via `just test`. Runtime tracer modularisation (Milestone 5) and final integration cleanup remain in flight.  
-5. Confirm behaviour parity after Milestones 5–6, then revisit this ADR for sign-off and capture any follow-up tasks surfaced during the rollout.
+4. **Status snapshot (2025‑03‑12):** Milestones 1–6 are complete—the runtime tracer collaborators, monitoring plumbing, and integration cleanups all landed with `just test` (nextest + pytest) coverage, Python benchmark parity, and documentation updates.  
+5. Confirmed behaviour parity and flipped the ADR to **Accepted**; any follow-up regressions will be handled via normal maintenance triage.

design-docs/codetracer-architecture-refactor-implementation-plan.status.md

@@ -87,6 +87,7 @@
 - ✅ Milestone 5 Step 6: harmonised the tracer module facade by tightening `IoCoordinator` visibility, pruning unused re-exports, documenting the `runtime::tracer` layout, and updating design docs that referenced the legacy `runtime_tracer.rs` path. `just test` (Rust nextest + Python pytest) verified the cleanup.
 - 🔄 Milestone 6 Kickoff: audited crate exports to keep the new module tree internal by default (runtime tracer collaborators + monitoring submodules now `pub(crate)`), and confirmed packaging metadata/docs already reference the updated paths so no additional adjustments are required yet. Pending follow-up: sweep for dead imports and finalise documentation/CI updates before ADR 0011 sign-off.
 - ✅ Milestone 6 Step 1: realigned the Python trace filter benchmark to account for the always-prepended `builtin-default` filter when validating metadata, restoring the smoke test with `just test` (nextest + pytest) coverage.
+- ✅ Milestone 6 Step 2: finished the integration cleanup—tightened monitoring callback logging to use the new table metadata, confirmed no stale doc references or build script changes were required, and re-ran `just test` (nextest + pytest) as the final verification before ADR 0011 acceptance.
 
 
 ### Planned Extraction Order (Milestone 4)
@@ -117,5 +118,5 @@
 5. **Tests:** After each move, update unit tests in `trace_filter` modules and dependent integration tests (`session/bootstrap.rs` tests, `runtime` tests). Targeted command: `just test` (covers Rust + Python suites).
 
 ## Next Actions
-1. Scope the Milestone 6 integration/cleanup tasks (CI configs, packaging metadata, doc updates) now that the runtime tracer refactor is complete.
-2. Track stakeholder feedback and spin out follow-up issues if new risks surface.
+1. Communicate completion to stakeholders and monitor for regression reports during adoption.
+2. Archive supporting notes and update any external runbooks that referenced the pre-refactor layout.