Skip to content

Commit 4028a5c

Browse files
committed
Fix python benchmark test
1 parent 2788a5b commit 4028a5c

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

codetracer-python-recorder/tests/python/perf/test_trace_filter_perf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ def test_trace_filter_perf_smoke(tmp_path: Path) -> None:
199199
assert glob.duration_seconds > 0
200200
assert regex.duration_seconds > 0
201201

202-
assert baseline.filter_names == ["bench-baseline"]
202+
assert baseline.filter_names == ["builtin-default", "bench-baseline"]
203203
assert "bench-glob" in glob.filter_names
204204
assert "bench-regex" in regex.filter_names
205205

design-docs/codetracer-architecture-refactor-implementation-plan.status.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@
8686
- ✅ Milestone 5 Step 5: shifted event handling into `runtime::tracer::events`, relocating the `Tracer` trait implementation alongside failure-injection helpers and telemetry wiring. `RuntimeTracer` now exposes a slim collaborator API (`mark_event`, `flush_io_before_step`, `ensure_function_id`), while tests import the trait explicitly. `just test` (nextest + pytest) confirms the callbacks behave identically after the split.
8787
- ✅ Milestone 5 Step 6: harmonised the tracer module facade by tightening `IoCoordinator` visibility, pruning unused re-exports, documenting the `runtime::tracer` layout, and updating design docs that referenced the legacy `runtime_tracer.rs` path. `just test` (Rust nextest + Python pytest) verified the cleanup.
8888
- 🔄 Milestone 6 Kickoff: audited crate exports to keep the new module tree internal by default (runtime tracer collaborators + monitoring submodules now `pub(crate)`), and confirmed packaging metadata/docs already reference the updated paths so no additional adjustments are required yet. Pending follow-up: sweep for dead imports and finalise documentation/CI updates before ADR 0011 sign-off.
89+
- ✅ Milestone 6 Step 1: realigned the Python trace filter benchmark to account for the always-prepended `builtin-default` filter when validating metadata, restoring the smoke test with `just test` (nextest + pytest) coverage.
8990

9091

9192
### Planned Extraction Order (Milestone 4)

0 commit comments

Comments
 (0)