Stage 5

Author: tzanko-matev

design-docs/function-level-srp-refactor-plan.md

@@ -22,6 +22,13 @@ These functions currently exceed 60–120 lines and interleave control flow with
 3. **Add regression tests around extracted helpers** so that future changes to callbacks can lean on focused coverage instead of broad integration tests.
 4. **Maintain behavioural parity** by running full `just test` plus targeted fixture comparisons after each stage.
 
+### Helper Module Map
+- `runtime::frame_inspector` owns frame discovery and locals/globals snapshots through the `FrameSnapshot` abstraction.
+- `runtime::value_capture` centralises argument, scope, and return-value recording, keeping encoding concerns outside the tracer façade.
+- `runtime::logging` provides the `log_event` helper so callback logging stays consistent and format-agnostic.
+- `session::bootstrap` deals with filesystem setup, format resolution, and program metadata collection for the Rust entrypoint.
+- Python `session.py` mirrors the responsibilities with `_coerce_format`, `_validate_trace_path`, and `_normalize_activation_path` helpers.
+
 ## Work Breakdown
 
 ### Stage 0 – Baseline & Guardrails (1 PR)
@@ -87,4 +94,3 @@ These functions currently exceed 60–120 lines and interleave control flow with
 - **Unsafe code mistakes:** Wrap raw pointer usage in RAII helpers with debug assertions; add fuzz/ stress tests for recursion-heavy scripts.
 - **Performance regressions:** Benchmark tracer overhead before and after major stages; inline trivial helpers where necessary, or mark with `#[inline]` as appropriate.
 - **Merge conflicts:** Finish each stage quickly and rebase branches frequently; keep PRs focused (≤400 LOC diff) to ease review.
-

design-docs/function-level-srp-refactor-plan.status.md

@@ -22,6 +22,11 @@
 - ✅ Exposed `record_return_value` in `runtime::value_capture` and refactored `RuntimeTracer::on_py_return` to orchestrate activation checks, logging, and value recording.
 - ✅ Extended runtime tests with explicit return capture coverage and activation deactivation assertions.
 
+## Stage 5 – Cleanup & Regression Sweep
+- ✅ Audited runtime modules for obsolete inline comments or TODOs introduced pre-refactor; none remained after helper extraction.
+- ✅ Documented the helper module map in `design-docs/function-level-srp-refactor-plan.md` for contributor onboarding.
+- ✅ Re-ran `just test` (Rust `cargo nextest` + Python `pytest`) to confirm post-cleanup parity.
+
 ## Next Actions
 - Draft short notes on activation gating and frame search mechanics to complete Stage 0.
-- Begin Stage 5 cleanup/regression sweep once Stage 0 notes are captured.
+- Track Stage 5 fixture comparisons if we decide to snapshot JSON/Binary outputs post-refactor.

trace.json/trace_metadata.json

@@ -0,0 +1 @@
+{"workdir":"/home/tzanko/code/repos/refactor-vc","program":"/home/tzanko/code/repos/refactor-vc/examples/value_capture_all.py","args":[]}

trace.json/trace_paths.json

@@ -0,0 +1 @@
+["/home/tzanko/code/repos/refactor-vc/examples/value_capture_all.py"]