Skip to content

Commit 0688bbd

Browse files
committed
fix(test): unskip gem installation tests
The gem installation tests were skipped due to a conditional bug that tested a string literal instead of the variable. This caused the library script to always use the PureRuby recorder and fail when running the native gem. Removed the skip and corrected the gem_bin check so the proper recorder class is chosen when generating the temporary script.
1 parent 63666c9 commit 0688bbd

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

test/test_tracer.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ def test_args_sum_with_separator
9595
end
9696

9797
def run_gem_installation_test(gem_bin, gem_module)
98-
skip
9998
Dir.chdir(File.expand_path('..', __dir__)) do
10099
gem_dir = File.join('gems', gem_bin)
101100

@@ -125,7 +124,7 @@ def run_gem_installation_test(gem_bin, gem_module)
125124
out_dir_lib = File.join('test', 'tmp', "gem_install_#{gem_bin.tr('-', '_')}_lib")
126125
FileUtils.rm_rf(out_dir_lib)
127126

128-
recorder_class = if '#{gem_bin}' == 'codetracer-ruby-recorder'
127+
recorder_class = if gem_bin == 'codetracer-ruby-recorder'
129128
"CodeTracer::RubyRecorder"
130129
else
131130
"Codetracer::PureRubyRecorder"

0 commit comments

Comments
 (0)