refactor: instead of passing to_s_id: ID parameter to value_to_string_safe, pass a Recorder structure, which contains all the interned IDs

Author: nickysn

gems/codetracer-ruby-recorder/ext/native_tracer/src/lib.rs

@@ -301,15 +301,15 @@ unsafe extern "C" fn call_to_s(arg: VALUE) -> VALUE {
     rb_funcall(data.0, data.1, 0)
 }
 
-unsafe fn value_to_string_safe(val: VALUE, to_s_id: ID) -> Option<String> {
+unsafe fn value_to_string_safe(recorder: &Recorder, val: VALUE) -> Option<String> {
     if RB_TYPE_P(val, rb_sys::ruby_value_type::RUBY_T_STRING) {
         let ptr = RSTRING_PTR(val);
         let len = RSTRING_LEN(val) as usize;
         let slice = std::slice::from_raw_parts(ptr as *const u8, len);
         return Some(String::from_utf8_lossy(slice).to_string());
     }
     let mut state: c_int = 0;
-    let data = (val, to_s_id);
+    let data = (val, recorder.to_s_id);
     let str_val = rb_protect(Some(call_to_s), &data as *const _ as VALUE, &mut state);
     if state != 0 {
         return None;
@@ -808,7 +808,7 @@ unsafe extern "C" fn event_hook_raw(data: VALUE, arg: *mut rb_trace_arg_t) {
 
         let class_name =
             cstr_to_string(rb_obj_classname(self_val)).unwrap_or_else(|| "Object".to_string());
-        let text = value_to_string_safe(self_val, recorder.to_s_id).unwrap_or_default();
+        let text = value_to_string_safe(recorder, self_val).unwrap_or_default();
         let self_type =
             TraceWriter::ensure_type_id(&mut *recorder.tracer, TypeKind::Raw, &class_name);
         let self_rec = ValueRecord::Raw {