Skip to content

Commit c9a0cee

Browse files
committed
refactor: value_to_string_safe() renamed value_to_string_exception_safe()
The new name should better reflect the intended meaning (as far as I can tell, based on reading some docs) behind the word 'safe', as used in this, ironically, and no pun intended, unsafe Rust function.
1 parent 74cb2e1 commit c9a0cee

File tree

1 file changed

+2
-2
lines changed
  • gems/codetracer-ruby-recorder/ext/native_tracer/src

1 file changed

+2
-2
lines changed

gems/codetracer-ruby-recorder/ext/native_tracer/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ unsafe extern "C" fn call_to_s(arg: VALUE) -> VALUE {
316316
rb_funcall(data.0, data.1, 0)
317317
}
318318

319-
unsafe fn value_to_string_safe(recorder: &Recorder, val: VALUE) -> String {
319+
unsafe fn value_to_string_exception_safe(recorder: &Recorder, val: VALUE) -> String {
320320
if RB_TYPE_P(val, rb_sys::ruby_value_type::RUBY_T_STRING) {
321321
rstring_lossy(val)
322322
} else {
@@ -777,7 +777,7 @@ unsafe extern "C" fn event_hook_raw(data: VALUE, arg: *mut rb_trace_arg_t) {
777777

778778
let class_name =
779779
cstr_to_string(rb_obj_classname(self_val)).unwrap_or_else(|| "Object".to_string());
780-
let text = value_to_string_safe(recorder, self_val);
780+
let text = value_to_string_exception_safe(recorder, self_val);
781781
let self_type =
782782
TraceWriter::ensure_type_id(&mut *recorder.tracer, TypeKind::Raw, &class_name);
783783
let self_rec = ValueRecord::Raw {

0 commit comments

Comments
 (0)