Refactor: Introduce Codetracer::KernelPatches module #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new module `Codetracer::KernelPatches` to centralize the monkey-patching logic for `Kernel#p`, `Kernel#puts`, and `Kernel#print`. Key changes: - Created `codetracer/kernel_patches.rb` for the new module. - The `Codetracer::KernelPatches` module now manages a list of active tracers. - Kernel methods are patched only once. Events are dispatched to all registered tracers. - `install(tracer)` and `uninstall(tracer)` methods allow tracers to register and unregister. - Original kernel methods are restored when the last tracer is uninstalled. - Event recording consistently uses `caller_locations(1,1).first` for path and line info. - Both the pure Ruby tracer (`trace.rb`) and the native tracer (`native_trace.rb`) have been updated to use this shared module. - Added comprehensive Minitest unit tests for `Codetracer::KernelPatches` covering various scenarios including multiple tracers and method restoration. This refactoring improves modularity, simplifies maintenance, and enables multiple tracer instances to coexist and receive kernel events simultaneously.
zah
added a commit
that referenced
this pull request
Jun 28, 2025
* Refactor: Introduce Codetracer::KernelPatches module This commit introduces a new module `Codetracer::KernelPatches` to centralize the monkey-patching logic for `Kernel#p`, `Kernel#puts`, and `Kernel#print`. Key changes: - Created `codetracer/kernel_patches.rb` for the new module. - The `Codetracer::KernelPatches` module now manages a list of active tracers. - Kernel methods are patched only once. Events are dispatched to all registered tracers. - `install(tracer)` and `uninstall(tracer)` methods allow tracers to register and unregister. - Original kernel methods are restored when the last tracer is uninstalled. - Event recording consistently uses `caller_locations(1,1).first` for path and line info. - Both the pure Ruby tracer (`trace.rb`) and the native tracer (`native_trace.rb`) have been updated to use this shared module. - Added comprehensive Minitest unit tests for `Codetracer::KernelPatches` covering various scenarios including multiple tracers and method restoration. This refactoring improves modularity, simplifies maintenance, and enables multiple tracer instances to coexist and receive kernel events simultaneously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new module
Codetracer::KernelPatchesto centralize the monkey-patching logic forKernel#p,Kernel#puts, andKernel#print.Key changes:
codetracer/kernel_patches.rbfor the new module.Codetracer::KernelPatchesmodule now manages a list of active tracers.install(tracer)anduninstall(tracer)methods allow tracers to register and unregister.caller_locations(1,1).firstfor path and line info.trace.rb) and the native tracer (native_trace.rb) have been updated to use this shared module.Codetracer::KernelPatchescovering various scenarios including multiple tracers and method restoration.This refactoring improves modularity, simplifies maintenance, and enables multiple tracer instances to coexist and receive kernel events simultaneously.