Skip to content

Commit 28964dd

Browse files
committed
cleanup: make it pass cargo clippy: for now allow Into without From
// allow it, because I am not sure we need it? // better to explicitly turn into the newtype types // but i might be wrong // also for now, allowing it to pass `cargo clippy`
1 parent af037e4 commit 28964dd

File tree

4 files changed

+16
-3
lines changed

4 files changed

+16
-3
lines changed

.github/workflows/rust.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,15 @@ env:
1010
CARGO_TERM_COLOR: always
1111

1212
jobs:
13-
build:
13+
lint:
14+
runs-on: ubuntu-latest
15+
16+
steps:
17+
- uses: actions/checkout@v4
18+
- name: Lint
19+
run: cargo clippy
20+
21+
build-and-test:
1422

1523
runs-on: ubuntu-latest
1624

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "runtime_tracing"
3-
version = "0.5.14-experimental-5"
3+
version = "0.5.14-experimental-7"
44
edition = "2021"
55

66
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

src/lib.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
// allow it, because I am not sure we need it?
2+
// better to explicitly turn into the newtype types
3+
// but i might be wrong
4+
// also for now, allowing it to pass `cargo clippy`
5+
#![allow(clippy::from_over_into)]
16
mod tracer;
27
mod types;
38
pub use crate::tracer::{Tracer, NONE_TYPE_ID, NONE_VALUE};

src/tracer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ impl Tracer {
119119

120120
pub fn register_step(&mut self, path: &Path, line: Line) {
121121
let path_id = self.ensure_path_id(path);
122-
self.events.push(TraceLowLevelEvent::Step(StepRecord { path_id, line: line }));
122+
self.events.push(TraceLowLevelEvent::Step(StepRecord { path_id, line}));
123123
}
124124

125125
pub fn register_call(&mut self, function_id: FunctionId, args: Vec<FullValueRecord>) {

0 commit comments

Comments
 (0)