Support wasm32-wasip1 as a target
#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SersemPeca
force-pushed
the
feat/compress-with-ruzstd
branch
2 times, most recently
from
e552279 to
968c722
Compare
SersemPeca
changed the title
ruzstd instead of zeekstdwasm32-wasip1 as a target
alehander92
reviewed
Aug 28, 2025
Collaborator
|
What about other targets, that are neither x86_64, nor wasm32? E.g. aarch64, etc. |
Contributor
Author
|
A valid comment. I'll change it so that we fall back to the rust rewrite of |
SersemPeca
force-pushed
the
feat/compress-with-ruzstd
branch
3 times, most recently
from
694c5df to
688a563
Compare
alehander92
requested changes
Aug 29, 2025
Member
alehander92
left a comment
alehander92
left a comment
There was a problem hiding this comment.
ok, seems that now it should preserve the old behavior with no wasm
just need to update the vesion in Cargo.toml
SersemPeca
force-pushed
the
feat/compress-with-ruzstd
branch
from
4c32397 to
1a16f67
Compare
Member
|
merging: @nickysn reminded us correctly to test if zeekstd works with aarch64: TODO separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites our compression logic to use
ruzstdinstead ofzeekstd, since ruzstd can be build for wasm targets