fix: load user config even for inTest, pass CODETRACER_TEST=1 for ui tests

this way the stepping tests by Nedy now work just with `just test-e2e

Author: alehander92

src/common/config.nim

@@ -102,13 +102,14 @@ proc findConfig*(folder: string, configPath: string): string =
         config = true
 
 proc loadConfig*(folder: string, inTest: bool): Config =
+  # ignore inTest from now: TODO eventually remove?
   var file = findConfig(folder, configPath)
   if file.len == 0:
     file = userConfigDir / configPath
     createDir(userConfigDir)
     copyFile(configDir / defaultConfigPath, userConfigDir / configPath)
-  if inTest:
-    file = codetracerTestDir / testConfigPath
+  # if inTest:
+  #   file = codetracerTestDir / testConfigPath
   var raw = ""
   try:
     raw = readFile(file)

src/frontend/index.nim

@@ -1402,7 +1402,7 @@ proc init(data: var ServerData, config: Config, layout: js, helpers: Helpers) {.
   # config <- file config combined with cli args and other setup
   # improve this code
 
-  data.config.test = data.config.test or data.startOptions.inTest
+  data.config.test = data.config.test #  or data.startOptions.inTest
   # TELEMETRY_ENABLED = false
   # data.layout = layout
   # data.helpers = helpers

src/frontend/index_config.nim

@@ -1253,8 +1253,9 @@ proc loadConfig*(main: js, startOptions: StartOptions, home: cstring = j"", send
       errorPrint "  to: ", fmt"{userConfigDir / configPath}"
       quit(1)
 
-  if startOptions.inTest:
-    file = nodePath.join(j(codetracerTestDir), j(testConfigPath))
+  # TODO: maybe remove config test logic?
+  # if startOptions.inTest:
+    # file = nodePath.join(j(codetracerTestDir), j(testConfigPath))
   infoPrint "index: load config ", file
   let (s, err) = await fsreadFileWithErr(file)
   if not err.isNil:
@@ -1310,8 +1311,9 @@ proc loadHelpers*(main: js, filename: string): Future[Helpers] {.async.} =
 
 proc saveConfigTheme*(main: js, theme: cstring): Future[void] {.async.} =
   var file = j(userConfigDir)
-  if data.startOptions.inTest:
-    file = j(configDir & testConfigPath)
+  # TODO: maybe remove inTest config logic?
+  # if data.startOptions.inTest:
+    # file = j(configDir & testConfigPath)
   let (s, err) = await fsReadFileWithErr(file)
   if not err.isNil:
     errorPrint "read config file for theme error: ", err

ui-tests/tests/lib/ct_helpers.ts

@@ -159,6 +159,7 @@ async function replayCodetracerInElectron(
   process.env.CODETRACER_CALLER_PID = runPid.toString();
   process.env.CODETRACER_TRACE_ID = traceId.toString();
   process.env.CODETRACER_IN_UI_TEST = "1";
+  process.env.CODETRACER_TEST = "1";
   process.env.CODETRACER_WRAP_ELECTRON = "1";
   process.env.CODETRACER_START_INDEX = "1";
 

ui-tests/tests/noir/stepping.spec.ts

@@ -4,7 +4,7 @@ import { test, expect } from "@playwright/test";
 import {
   // window,
   // page,
-  wait,
+  // wait,
   // debugCodetracer,
   readyOnEntryTest as readyOnEntry,
   clickNext,
@@ -17,7 +17,7 @@ ctRun("noir_example/");
 
 test("continue", async () => {
   await readyOnEntry();
-  await wait(5_000);
+  // await wait(5_000);
   await clickContinue();
   expect(true);
 });