Skip to content

Commit d28a986

Browse files
zahclaude
andcommitted
fix(ci): Remove obsolete .gitmodules SSH-to-HTTPS rewrite steps
The rr-backend repo already uses HTTPS URLs in .gitmodules, so the sed rewrite is a no-op. The subsequent git commit then fails with "nothing to commit", breaking both test-ui-tests-rr and rr-backend-tests. The git config URL rewrites (insteadOf) already handle authenticated cloning, making the .gitmodules file modification unnecessary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent d83de1b commit d28a986

File tree

2 files changed

+0
-19
lines changed

2 files changed

+0
-19
lines changed

.github/workflows/cross-repo-tests.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,6 @@ jobs:
7777
path: ${{ github.workspace }}/../codetracer-rr-backend
7878
gh-token: ${{ secrets.GH_READ_METACRAFT_PRIVATE_REPOS }}
7979

80-
# Rewrite .gitmodules SSH URLs to HTTPS so nix's internal git fetcher
81-
# can resolve submodules when evaluating the flake with submodules=1.
82-
- name: Rewrite rr-backend .gitmodules for nix
83-
run: |
84-
CLONE_DIR="$(pwd)/../codetracer-rr-backend"
85-
cd "$CLONE_DIR"
86-
sed -i 's|git@github.com:|https://github.com/|g' .gitmodules
87-
sed -i 's|ssh://git@github.com/|https://github.com/|g' .gitmodules
88-
git add .gitmodules
89-
git -c user.name="CI" -c user.email="ci@local" commit --no-gpg-sign -m "CI: rewrite submodule URLs to HTTPS"
90-
9180
- name: Build ct-rr-support
9281
run: |
9382
CLONE_DIR="$(pwd)/../codetracer-rr-backend"

ci/setup-rr-backend.sh

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,6 @@ clone_rr_backend() {
8989
git config "$url" "$new_url"
9090
done
9191
git submodule update --recursive
92-
93-
# Rewrite .gitmodules SSH URLs to HTTPS so nix's internal git fetcher
94-
# can resolve submodules when evaluating the flake with submodules=1
95-
sed -i 's|git@github.com:|https://github.com/|g' .gitmodules
96-
sed -i 's|ssh://git@github.com/|https://github.com/|g' .gitmodules
97-
# Stage and commit the rewrite so nix sees it in the git tree
98-
git add .gitmodules
99-
git -c user.name="CI" -c user.email="ci@local" commit --no-gpg-sign -m "CI: rewrite submodule URLs to HTTPS"
10092
)
10193
}
10294

0 commit comments

Comments
 (0)