Skip to content

Allow restart subprocess to search ct on PATH #429

@tzanko-matev

Description

@tzanko-matev

💡 Codex Review

let process = startProcess(codetracerExe, args = @["replay", fmt"--id={recordedTrace.id}"], options = {poParentStreams})
waitForExit(process) == RESTART_EXIT_CODE

P1 Badge Allow restart subprocess to search ct on PATH

When the binaries are built for the Python wheel, codetracerExe is compiled as the plain string "ct" rather than an absolute path. The restart branch here still launches startProcess with only {poParentStreams}, so the Nim runtime tries to execute a relative file and fails with OSError: no such file on installations that rely on PATH lookup (the newly added Python package). Other call sites were updated to pass poUsePath for this exact scenario. Add poUsePath (or resolve an absolute path) so the replay restart works in wheel-based deployments.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Originally posted by @chatgpt-codex-connector[bot] in #419 (review)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions