Tup refactor #420
Open
Tup refactor #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.agents/codebase-insights.txt: 0006-tup-build-staging-area.md: justfile: tup-build-staging-implementation-plan.md: Signed-off-by: Tzanko Matev <[email protected]>
.agents/codebase-insights.txt: nix/shells/main.nix: src/Tupfile: src/Tuprules.tup: src/backend-manager/Tupfile: src/build/.gitignore: src/build/Tupfile: src/build/Tuprules.tup: src/build/backend-manager/Tupfile: src/build/ct/Tupfile: src/build/db-backend/Tupfile: src/build/db-backend/tree-sitter-trace/Tupfile: src/build/frontend/styles/Tupfile: src/build/public/Tupfile: src/build/public/resources/Tupfile: src/build/public/resources/calltrace/Tupfile: src/build/public/resources/debug/Tupfile: src/build/public/resources/fonts/Tupfile: src/build/public/resources/fonts/fira_code/Tupfile: src/build/public/resources/fonts/space_grotesk/Tupfile: src/build/public/resources/menu/Tupfile: src/build/public/resources/shared/Tupfile: src/build/public/resources/shell/Tupfile: src/build/public/resources/tracepoints/Tupfile: src/build/public/third_party/Tupfile: src/build/small-lang/Tupfile: src/build/tester/Tupfile: src/build/tui/Tupfile: src/ct/Tupfile: src/ct/ct_wrapper.nim: src/db-backend/Tupfile: src/db-backend/tree-sitter-trace/Tupfile: src/frontend/styles/Tupfile: src/public/Tupfile: src/public/resources/Tupfile: src/public/resources/calltrace/Tupfile: src/public/resources/debug/Tupfile: src/public/resources/fonts/Tupfile: src/public/resources/fonts/fira_code/Tupfile: src/public/resources/fonts/space_grotesk/Tupfile: src/public/resources/menu/Tupfile: src/public/resources/shared/Tupfile: src/public/resources/shell/Tupfile: src/public/resources/tracepoints/Tupfile: src/public/third_party/Tupfile: src/small-lang/Tupfile: src/tester/Tupfile: src/tui/Tupfile: tup-build-staging-status.md: Signed-off-by: Tzanko Matev <[email protected]>
.agents/codebase-insights.txt: 0006-tup-build-staging-area.md: tup-build-staging-implementation-plan.md: tup-build-staging-status.md: Signed-off-by: Tzanko Matev <[email protected]>
ci/build/dev.sh: docs/a.md: docs/book/src/installation.md: docs/tests.md: justfile: nix/shells/armShell.nix: non-nix-build/env.sh: src/db-backend/editor-config/emacs/init.el: tup-build-staging-status.md: wdio.conf.js: Signed-off-by: Tzanko Matev <[email protected]>
ci/build/dev.sh: ci/test/python-recorder-smoke.sh: ci/test/ui-tests.sh: justfile: Signed-off-by: Tzanko Matev <[email protected]>
tzanko-matev
force-pushed
the
tup-refactor
branch
from
7be4865 to
955c7b2
Compare
This is needed for the ui tests to run in Github. We need to pass the `--no-sandbox` argument to electron. In the previous version of the code the code path used to start electron was not doing that. ci/test/ui-tests.sh: Add CODETRACER_ELECTRON_ARGS=--no-sandbox Signed-off-by: Tzanko Matev <[email protected]>
tzanko-matev
force-pushed
the
tup-refactor
branch
from
955c7b2 to
38d95a9
Compare
Signed-off-by: Tzanko Matev <[email protected]>
tzanko-matev
force-pushed
the
tup-refactor
branch
from
38d95a9 to
5527a63
Compare
tzanko-matev
force-pushed
the
tup-refactor
branch
from
af5f73b to
22761c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose in this PR a refactoring of our tup setup. The main change is that we move all Tupfiles from
./srcto./src/buildConsequences:
When we run
tupusing the normal process (just buildorjust build-once) the output is now found in./src/build-debug/buildinstead of./src/build-debugAs a result all paths that relied on the previous location of the output artefacts needed to be updated.We had to change the logic in nim for locating ct_paths.json in order to be more robust. Now it should not depend where the
ctbinary is located as long as it is in a subfolder of the root repoWe can now use
tup generatelocally without too much trouble. The way to do it is:cd src; tup generate --config build-config/tup.conf tup.sh; tup.shAll build outputs will end up in./src/build. NOTE: after a single use we must clean up our repo in order to be able to use the normal dev flow again. The commands for that are:git clean -fx src/build; git clean -fx src/build-debugIt is now possible to run
./ci/build/dev.shlocally since it depends ontup generateIt is now possible to run all CI scripts which depend on dev.sh. Those are the python-smoke-test.sh and the ui-test.sh
ui-tests CI step is turned back on and should be working now
It should be easier to use Codex in codetracer, because it can use the
tup generateflow to build the code in its sandbox. This was not possible with tup. Instructions for Codex are not added to this PR though.