Fix printing unknown values across multiple records. (#269)

Author: blackwinter

README.md

@@ -566,6 +566,7 @@ Options:
 
 Additional options when printing unknown values:
 
+- `append`: Whether to open files in append mode if they exist. (Default: `true`)
 - `compression` (file output only): Compression mode. (Default: `auto`)
 - `destination`: Destination to write unknown values to; may include [format directives](https://docs.oracle.com/javase/8/docs/api/java/util/Formatter.html#syntax) for counter and record ID (in that order). (Default: `stdout`)
 - `encoding` (file output only): Encoding used by the underlying writer. (Default: `UTF-8`)

build.gradle

@@ -41,7 +41,7 @@ subprojects {
       'jquery':         '3.3.1-1',
       'junit_jupiter':  '5.8.2',
       'junit_platform': '1.4.2',
-      'metafacture':    'metafacture-core-5.4.1-rc1',
+      'metafacture':    'metafacture-core-5.4.1-rc3',
       'mockito':        '2.27.0',
       'requirejs':      '2.3.6',
       'slf4j':          '1.7.21',

metafix/src/main/java/org/metafacture/metafix/FixMethod.java

@@ -515,6 +515,7 @@ public void apply(final Metafix metafix, final Record record, final List<String>
             });
 
             if (printUnknown) {
+                options.putIfAbsent("append", "true");
                 withWriter(options, null, consumer);
             }
             else {

metafix/src/main/java/org/metafacture/metafix/api/FixFunction.java

@@ -49,6 +49,7 @@ default void withWriter(final Map<String, String> options, final UnaryOperator<S
         final String destination = options.getOrDefault("destination", ObjectWriter.STDOUT);
         final ObjectWriter<String> writer = new ObjectWriter<>(operator != null ? operator.apply(destination) : destination);
 
+        withOption(options, "append", writer::setAppendIfFileExists, this::getBoolean);
         withOption(options, "compression", writer::setCompression);
         withOption(options, "encoding", writer::setEncoding);
         withOption(options, "footer", writer::setFooter);

metafix/src/test/java/org/metafacture/metafix/MetafixLookupTest.java

@@ -934,7 +934,12 @@ public void shouldPrintUnknownWithSeparator() {
 
     @Test
     public void shouldPrintUnknownToFile() throws IOException {
-        MetafixTestHelpers.assertTempFile("you\ntoo\n", p -> shouldPrintUnknown(", destination: '" + p + "'", null, ""));
+        MetafixTestHelpers.assertTempFile("Hey\nyou\nthere\nyou\ntoo\n", p -> shouldPrintUnknown(", destination: '" + p + "'", null, ""));
+    }
+
+    @Test
+    public void shouldPrintUnknownToFileWithoutAppend() throws IOException {
+        MetafixTestHelpers.assertTempFile("you\ntoo\n", p -> shouldPrintUnknown(", destination: '" + p + "', append: 'false'", null, ""));
     }
 
     private void assertMap(final String... fixDef) {